Fix Windows UIA contract parity - #421
Merged
Merged
Conversation
Expose workspace lifecycle controls through the native provider, keep the Zig contract aligned with the fixed table, and enforce the relationship in CI. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Reject native fixed automation IDs that lack a corresponding Zig contract entry, including duplicate native IDs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace-switch-*childrenAccessibility.defaultContract()with the native fixed element table and replace index-based assertions with id lookupsCloses #417.
Evidence
RED: mutate native
workspace-newid ->default contract ids match the native fixed element tablefails and names missingworkspace-newRED: add native-only
native-only-mutatedid -> the same test fails and names the unmatched native idGREEN: restore both mutations -> Zig 0.15.2 accessibility tests, full Windows build, and native UIA live gate pass
REGRESSION: pinned Windows shell contract suite -> 100 tests pass and reports
Windows shell scaffold contract: PASSAdditional validation:
zig build -Dwinghostty-dir=D:\depot\Winghostty-pinnedwith Zig 0.15.2Tools\windows\uia-live-gate.ps1against the built shell and pinned zmx providerTools\windows\validate.ps1 -Task windows-shell -SkipTrayLivewas attempted, but its prerequisite Swift release build failed before Windows validation with missing_complexanducrtmodules in the local Swift environmentThe parity matrix remains Partial because terminal
ITextProvider, daemon-to-model UIA integration, and remaining dialogs still lack complete end-to-end evidence.