Repository navigation
Document Coverage as a required check - #20
Merged
Merged
Conversation
The Coverage job passed on its first run, measuring 95.89% of lines on Linux, and joins the checks the ruleset requires before anything merges to main. GOVERNANCE.md lists it with the other required checks, and §11 of docs/architecture.md moves it from the checks that are only reported to the table of required ones, now 11. Signed-off-by: Jim Schreckengast <schreck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The ruleset itself isn't changed here. That happens in the repository settings: add
Coverage(GitHub Actions) to the required status checks of the "Protect main" ruleset. These docs describe the state once that's done.Why
Coverage passed on its first run, in #19: 95.89% of lines on Linux, with 452 of 10,991 missed, against a floor of 80%. Because it was only reported, #19 merged about three minutes before the job finished. A change that dropped coverage below 80% could have merged the same way. Requiring the check keeps that floor, which the test_statement_coverage80 criterion of the OpenSSF Best Practices silver badge relies on.
The cost is time. The job took 9 min 20 s on its first run, with nothing cached. That is longer than any check required today; CodeQL's Rust analysis takes about 6 min. About 4.4 min of it was setup and the build, which caching may shorten on later runs.
Testing
Docs only. No doc still calls Coverage optional, and the Mermaid diagram has no leftover references to the removed node.