Conversation
nvaytet
reviewed
Aug 10, 2026
| def test_back_and_forward_buttons_navigate_view_history(ndim): | ||
| da = data_array(ndim=ndim) | ||
| p = da.plot() | ||
| toolbar = p.canvas.fig.canvas.toolbar |
Member
There was a problem hiding this comment.
I got slightly confused here, because toolbar is the matplotlib toolbar. I guess you need that to be able to do push_current(). But I thought below we were then testing clicking buttons on the mpl toolbar. It's easy to miss that toolbar is the mpl one, and p.toolbar is our toolbar.
Can we either change the variable name or add a comment (or both)?
nvaytet
approved these changes
Aug 10, 2026
jokasimr
enabled auto-merge
August 10, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #587