test: qualify Linux NVMe read depth without hiding amplification - #61
Merged
Merged
Conversation
POSIX worker sweeps were capped by the default client count, so extra workers never reached device depth. Report in-flight peak and Direct read amplification so payload throughput is not mistaken for device bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--features io-uring.in_flight_peak, configured depth, slot wait, payload bytes, andread_amponresult phase=read_io, and document that Linux NVMe read depth belongs to caller concurrency rather than extra rings.Design Notes
IOPOLL remains an optional follow-up (
CACHE_BENCH_IO_URING_READ_IOPOLL=true) rather than a default qualification cell. On the measured ext4 NVMe host it ran, but it did not raise Direct 16 KiB payload throughput once in-flight depth already saturated the device after size-class alignment amplification.Test plan
cargo x checkcargo x testcargo x lintqualify-linux-nvme.sh5-sample / 30-minute soak on a dedicated NVMe host