Repository navigation
fix: stop waiting for input on interrupt - #8
Merged
Merged
Conversation
A prompt read cannot be interrupted by a signal, so Ctrl+C at a prompt waited until the line was submitted. Cancel the read with the command context and render interruptions as a bare newline.
tisonkun
reviewed
Sep 11, 2026
tisonkun
reviewed
Sep 11, 2026
Comment on lines
+49
to
+55
| func renderError(err error) string { | ||
| // An interrupted command ends the pending line instead of reporting a failure the user already knows about. | ||
| if clierror.ExitCode(err) == clierror.ExitInterrupted { | ||
| return "\n" | ||
| } | ||
| return clierror.Render(err) | ||
| } |
Contributor
There was a problem hiding this comment.
.. and then this function can be inlined further.
Contributor
|
I'm patching this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope loginorscope apikey revokeexits promptly with the interrupted exit code instead of waiting for the line to be submitted.Design Notes
os.Stdinreads cannot be interrupted by a signal: the descriptor is not registered with the runtime poller, soSetReadDeadlinereportsos.ErrNoDeadlineandinternal/pollretries the read onEINTR.readLinetherefore reads in a goroutine and stops waiting once the command context ends.