Repository navigation
docs(lens): exact_matches and product are not supported — say so (SCR-177) - #45
Merged
Merged
Conversation
…-177) They have never filtered anything. Google renders both tabs client-side and five routes into them returned nothing, so the API reports each dropped parameter in a `warnings` array instead of charging full price for a silent no-op. Reported as SB-001104; fixed upstream in scrape-badger/scrapebadger#2259. `query` DOES now work (LensOverlay query_metadata.text_query), so the example points at it instead of `product`. Hand-edited because generate.sh builds this facade from this repo's main, not from the OpenAPI spec — the spec-generated SDKs got the correction for free. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lens
exact_matches/productdocs here are false, and this SDK is not reached by codegen.Upstream fix: scrape-badger/scrapebadger#2259 (SCR-177), from support ticket SB-001104 — a customer set
exact_matches=trueto find pages hosting his photo for copyright claims, paid 7 credits a call, and got the unfiltered visual-match grid with nothing marking the exact match. The parameter had never been wired to anything. Over 60 days: 1,079 such calls from 9 accounts, 5,117 credits.Google keeps exact matches and products behind tabs it renders client-side, and five separate routes into them all returned nothing, so the API now names every dropped parameter in a
warningsarray on the response rather than silently charging for a no-op.querywas equally dead and is now genuinely wired (via the LensOverlayquery_metadata.text_query), so it is worth pointing users at.Why this needs a hand edit:
sdk/codegen/generate.shbuilds the python and node facades by cloning this repo'smainand layering spec-derived additions on top, so existing v1 method docs come from here, not from the OpenAPI spec. The ten spec-generated SDKs (php, go, rust, java, …) picked the correction up automatically once scrape-badger/scrapebadger#2261 unblocked SDK Codegen; these two cannot.No signature or behaviour change — documentation only.
🤖 Generated with Claude Code