Skip to content

Rephrase XXX comment, drop stale pseudo-element TODO #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wRAR merged 1 commit into from
Sep 22, 2026
+1 −2
Merged

Rephrase XXX comment, drop stale pseudo-element TODO #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cssselect/xpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class GenericTranslator:
"^=": "prefixmatch",
"$=": "suffixmatch",
"*=": "substringmatch",
"!=": "different", # XXX Not in Level 3 but meh
"!=": "different", # not part of Selectors Level 3, but widely supported
}

#: The attribute used for ID selectors depends on the document language:
Expand Down Expand Up @@ -412,7 +412,6 @@ def xpath_pseudo(self, pseudo: Pseudo) -> XPathExpr:
getattr(self, method_name, None),
)
if not method:
# TODO: better error message for pseudo-elements?
raise ExpressionError(f"The pseudo-class :{pseudo.ident} is unknown")
return method(self.xpath(pseudo.selector))

Expand Down
Loading