fix: don't close peer connection on transient 'disconnected' state - #250
Merged
Merged
Conversation
Both connectionstatechange handlers treated 'disconnected' the same as 'closed' and 'failed' and immediately called peer.close(). Per the WebRTC spec, 'disconnected' only means that ICE connectivity checks are currently failing. The connection frequently recovers on its own -- brief network hiccups, Wi-Fi roaming between access points, or NAT rebinding all trigger it. Calling close() makes that recovery impossible, because a closed RTCPeerConnection cannot be reopened. The result was that a short network glitch permanently killed the stream and the viewer had to reload the page. Leaving 'disconnected' unhandled lets the browser's own ICE recovery do its job. Refs screego#53
jmattheis
force-pushed
the
fix/transient-disconnected
branch
from
August 20, 2026 18:25
d1f2b39 to
9f87229
Compare
jmattheis
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 😊
both connectionstatechange handlers treated 'disconnected' the same as 'closed' and 'failed' and immediately called peer.close().
Per the WebRTC spec, 'disconnected' only means that ICE connectivity checks are currently failing. The connection frequently recovers on its own -- brief network hiccups☺️ , Wi-Fi roaming between access points, or NAT rebinding all trigger it. Calling close() makes that recovery impossible, because a closed RTCPeerConnection cannot be reopened.
The result was that a short network glitch permanently killed the stream and the viewer had to reload the page. Leaving 'disconnected' unhandled lets the browser's own ICE recovery do its job.
Refs #53