MapPerms: Consistency between map and iomap#577
Open
cazb2 wants to merge 1 commit into
Open
Conversation
This commit unifies the way VM rights are encoded in the sdf. Previously normal map perms were represented as a raw u8 while the iomap perms were represented as a proper type. Preserves existing behaviour. Signed-off-by: Callum <c.berry@student.unsw.edu.au>
Contributor
Author
|
seL4 reference for write only run time error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit unifies the way VM rights are encoded in the sdf. Previously normal map perms were represented as a raw u8 enum while the iomap perms were represented as a proper type.
This uses a base enum for the vm rights and then uses a context specific struct around the base rights depending on if the perms are for a iomap or map entry.
This preserves existing correct behaviour, (I believe seL4 would reject the WriteExecute case where the tool would previously accept this for normal frames leading to a runtime error.)