Repository navigation
CI: run the HTTPS integration suite on pull requests that touch it - #73
Merged
Merged
Conversation
test-slow-suites is gated on schedule or workflow_dispatch, and the schedule is weekly, so https_fetch_test.sql -- the only coverage for the part of the project with the messiest failure modes (TLS verification, read timeouts, credential decryption) -- effectively ran once a week. A broken change could sit on main for six days before anything noticed. Add a job that runs just the integration suite on pull requests that change an HTTPS file. The performance suite is deliberately left on the weekly schedule: it is slow and sensitive to runner load, so running it per-PR would buy noise rather than signal. File detection matches "https" in the basename rather than an explicit path list, so it keeps working if the HTTPS SQL is renamed or moved. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017nq3xZcPqSTKtskyP2DzkK
seanwevans
deleted the
claude/pg-git-upgrade-deps-rk0oxk-ci-https-tests
branch
September 3, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
test-slow-suitesis gated onscheduleorworkflow_dispatch, and the schedule is weekly (0 6 * * 0). Sohttps_fetch_test.sql— the only coverage for the part of the project with the messiest failure modes (TLS verification, read timeouts, credential decryption) — effectively ran once a week. A broken change could sit onmainfor six days before anything noticed.The fix
Add
detect-https-changes+test-https-integration: on a pull request that changes an HTTPS file, run just the integration suite.The performance suite is deliberately left on the weekly schedule. It is slow and sensitive to runner load, so running it per-PR would buy noise rather than signal.
Notes for review
httpsin the basename rather than an explicit path list. Every HTTPS-related path in the repo has it (sql/functions/014-https.sql,test/sql/https_fetch_test.sql), and nothing else does, so the filter keeps working if that SQL is renamed or moved — which is exactly what #71 does.git diff --name-onlybetweenpull_request.base.shaand the merge commit, withfetch-depth: 0.pull_requesteventsdetect-https-changesis skipped, sotest-https-integrationis skipped too — the weekly job is unaffected.docker compose runinvocation mirrors the existingtest-slow-suitesstep, so it inherits the samedepends_on: service_healthywait.🤖 Generated with Claude Code
https://claude.ai/code/session_017nq3xZcPqSTKtskyP2DzkK
Generated by Claude Code