Support adding/removing workspace secret keys - #266
Merged
Conversation
schaloner
requested review from
bverbeken and
mroloux
and
a lite review from Copilot
and removed request for
a team
August 21, 2026 13:28
Contributor
There was a problem hiding this comment.
Pull request overview
Adds workspace secret-key management and rotation support to the Java SDK.
Changes:
- Adds APIs to add and remove workspace secret keys.
- Exposes workspace secret keys through
Workspace. - Adds integration tests for key management and regeneration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Summary |
|---|---|
src/test/java/seatsio/workspaces/RemoveSecretKeyTest.java |
Tests removing a workspace secret key. |
src/test/java/seatsio/workspaces/RegenerateWorkspaceSecretKeyTest.java |
Tests secret-key regeneration constraints. |
src/test/java/seatsio/workspaces/AddSecretKeyTest.java |
Tests adding a workspace secret key. |
src/main/java/seatsio/workspaces/Workspaces.java |
Implements secret-key management operations. |
src/main/java/seatsio/workspaces/Workspace.java |
Adds secretKeys; requires preserving the existing seven-argument constructor for compatibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mroloux
requested changes
Aug 21, 2026
mroloux
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.