Support add/remove secret keys - #158
Merged
Merged
Conversation
schaloner
requested review from
bverbeken and
mroloux
and removed request for
a team
August 24, 2026 12:42
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client support for managing multiple workspace secret keys (add/remove) and exposes the returned secretKeys list on the Workspace domain model, with accompanying workspace tests.
Changes:
- Add
add_secret_keyandremove_secret_keyAPIs toWorkspacesClient(including request payload type for removal). - Extend
Workspacedomain object to includesecret_keysfrom the API response. - Add tests covering adding and removing workspace secret keys; bump Node version used in the release workflow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
seatsio/workspaces/workspacesClient.py |
Adds add_secret_key/remove_secret_key methods and wires the remove request body. |
seatsio/workspaces/removeSecretKeyRequest.py |
Introduces request object for the remove-secret-key action payload. |
seatsio/domain.py |
Maps secretKeys from API JSON onto Workspace.secret_keys. |
tests/workspaces/testAddWorkspaceSecretKey.py |
Validates that adding a secret key returns a new key and is reflected on retrieval. |
tests/workspaces/testRemoveWorkspaceSecretKey.py |
Validates removing a specific secret key updates the retrieved secret_keys list. |
.github/workflows/release.yml |
Updates release workflow Node runtime to v22. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mroloux
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.