Drop the npm registry setup from the release workflow - #159
Merged
sdivelbiss merged 1 commit intoAug 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes npm registry configuration from the GitHub Actions release workflow to avoid setup-node@v7 auth-token behavior breaking yarn add, aligning with this repo’s release process (PyPI publish; Node is only used to run zx).
Changes:
- Dropped
registry-url: https://registry.npmjs.org/from theactions/setup-node@v7step in the release workflow.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sdivelbiss
marked this pull request as ready for review
August 24, 2026 19:33
sdivelbiss
requested review from
bverbeken,
mroloux and
schaloner
and removed request for
a team
August 24, 2026 19:33
mroloux
approved these changes
Aug 24, 2026
Contributor
Author
|
woah! late night approval! |
sdivelbiss
deleted the
scott/seats-1209-node_auth_token-needs-updating-in-seatsio-python
branch
August 24, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we never publish to npm here, removing the registry setup