Repository navigation
17.0.0: manual exposure crash fix; Portrait reworked and switched off - #275
Merged
Merged
Conversation
CommandAction.SetPortraitAperture = 36 carries the f-number in CommandParameters.portrait_aperture. CameraState.portrait reports the applied aperture and the range the camera accepts, present exactly when supports_portrait is set. A command with no f-number is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ture PortraitRenderer.render(_:aperture:aspectRatio:) is the still blur that lived in CaptureEngine, now at a given f-number. Its range comes from CIDepthBlurEffect's inputAperture attributes (f/1.4...f/16 if absent), default f/4.5. The engine stores the clamped aperture, reports it in PortraitState and uses it for every Portrait still. PortraitPreviewBlur is a pass-through stub for the live preview blur. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CameraControlling.setPortraitAperture forwards through CameraRig to the engine. The coordinator applies it in every phase but taking a picture (busy) and not-a-camera, answering once with the state tagged .setportraitaperture. Docs list it with the other control commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he capability CameraState.portrait replaces supports_portrait: a camera that can take Portrait stills reports the block, one that can't omits it. SetPortrait (action 36) carries portrait_aperture (0 = keep) and portrait_output (Unknown = keep). PortraitOutput is Baked or Editable; the camera opens Editable at f/4.5 and reports both. The aperture range is f/1.4...f/16, narrowed to what CIDepthBlurEffect accepts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ig settings Portrait's aperture and output are rig settings, like the aspect: one value each, sent with SetPortrait to every camera that reports a Portrait block and differs, re-sent to a camera that joins or comes back from a lens swap with something else, and counted in flight like every control command. The rig opens at what the first camera reports, and its ruler spans the range every camera accepts; a narrower camera narrows the rig. The screen reads the cameras' reports, never the tap. In Portrait mode the director shows an f-stop ruler (the exposure rulers' column pill, configured: log2, 1/3-stop clicks, full stops tall) and the rig tray gets an Editable / Baked picker with a one-line explanation. The mode labels and the new strings are in all 15 locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In Portrait the camera attaches an AVCaptureDepthDataOutput next to the photo depth delivery and keeps the newest disparity map. On the preview lane each frame is blurred with CIMaskedVariableBlur: the subject's disparity (median of the map's middle third) stays sharp, the radius grows away from it and with a wider aperture. Output keeps the input's pixel format and size. Outside Portrait the path is one atomic load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Editable (the default) delivers the capture file untouched, with depth, the portrait matte and the hair/skin/teeth/glasses mattes embedded, so Photos offers Depth Control. One pure decision, PortraitRenderer.delivery, picks bake, pass-through or plain crop. Portrait now asks for every offered semantic matte (on after depth, off before it) and embeds them per shot. depthBlurEffectFilter(forImageData:) loads disparity, matte, hair and glasses on its own; a test pins the inputs. A Baked still from a HEIC with a gain map runs the blur on the expanded HDR image too and Core Image writes a fresh gain map, keeping the capture's metadata and orientation (iOS 18+, HEIC; SDR path otherwise). The Portrait photo ceiling rises to 24MP, always picked from the format's own supportedMaxPhotoDimensions. The hardware test now covers both outputs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
📊 Test Coverage Report✅ 826/851 tests passed · ⏭️ 25 skipped
🎥 Capture & session core
📁 Full report — 104 files
Generated from |
A Portrait still is now always the capture file with its depth, so Photos draws the blur. The Baked output, its tray picker, the still renderer and the output field on the wire are gone; SetPortrait carries the f-number only. Portrait ships switched off: FeatureFlags.ENABLE_PORTRAIT_MODE is false, and CaptureEngine.offersPortrait is the one gate for what the camera reports and for depth capture. Wire: supports_portrait keeps its slot as deprecated and the PortraitState block is appended after it. Version 17.0.0 (build 132), with release notes for every locale. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is release 17.0.0. What users get is the manual exposure crash fix from #272. Portrait is in the build but switched off, so nobody sees it yet.
What users get
Portrait is off
FeatureFlags.ENABLE_PORTRAIT_MODEis false. With it off, no camera reports Portrait, so no remote offers the mode, and depth capture never turns on. There is one gate for all of that,CaptureEngine.offersPortrait.What Portrait is when the flag flips
Wire
CommandAction.SetPortrait = 36, carryingportrait_aperture.CameraState.portrait: PortraitState { aperture, min_aperture, max_aperture }. Its presence is the capability.supports_portraitkeeps its slot as deprecated, because build 131 (16.1.0) went up to App Store Connect with it.What was checked
testDepthTurnsWithTheFrame, fails because it expects phone rotation and a Mac does not rotate. It runs on the simulator in CI.Before the flag flips on
Nothing in Portrait has run on a phone since the first probe on an iPhone 18 Pro. Open items:
🤖 Generated with Claude Code