add mandatory test 6.1.54 - #700
Open
domachine wants to merge 1 commit into
Open
Conversation
domachine
force-pushed
the
feat/csaf-2.1-mandatory-test-6.1.54
branch
2 times, most recently
from
August 26, 2026 14:11
4c4fa6f to
e5c3a5c
Compare
domachine
force-pushed
the
feat/csaf-2.1-mandatory-test-6.1.54
branch
from
August 27, 2026 11:14
e5c3a5c to
f37eacc
Compare
domachine
force-pushed
the
feat/csaf-2.1-mandatory-test-6.1.54
branch
from
August 27, 2026 13:45
f37eacc to
6c152f1
Compare
|
Coverage after merging feat/csaf-2.1-mandatory-test-6.1.54 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bendo-eXX
requested changes
Aug 29, 2026
Contributor
There was a problem hiding this comment.
Parser does not enforce whitespace around WITH, AND, and OR
I think this part of the specification is not implemented correctly yet:
There MUST NOT be white space between a license-id and any following
+. This supports easy parsing and backwards compatibility. There MUST be white space on either side of the operatorWITH. There MUST be white space and/or parentheses on either side of the operatorsANDandOR.
To verify this, the following tests reproduce the issue:
it('requires white space on both sides of `WITH`', () => {
expect(() => parse('MIT WITHClasspath-exception-2.0')).to.throw(SyntaxError)
})
it('requires white space on both sides of `AND/OR`', () => {
expect(() => parse('MIT ANDClasspath-exception-2.0')).to.throw(SyntaxError)
expect(() => parse('MIT ORClasspath-exception-2.0')).to.throw(SyntaxError)
})
it('requires white space and/or parentheses on both sides of `AND`', () => {
// Missing separator on either side must be rejected
expect(() => parse('(MIT)ANDBSD-3-Clause')).to.throw(SyntaxError)
expect(() => parse('MITAND(BSD-3-Clause)')).to.throw(SyntaxError)
})Currently these expressions are parsed without throwing a SyntaxError, even though the spec requires whitespace (and/or parentheses) around WITH, AND, and OR. It looks like the parser/lexer doesn't enforce this separator rule strictly enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.