feat(perception): arm the reactivity ring on set_perception_enabled - #340
Open
jeffcrouse wants to merge 1 commit into
Open
feat(perception): arm the reactivity ring on set_perception_enabled#340jeffcrouse wants to merge 1 commit into
jeffcrouse wants to merge 1 commit into
Conversation
The ring only samples while "armed" (arm() sets an 8s window that due() gates push() on). Enabling perception flipped the master switch but did NOT arm, so the ring stayed cold until a later analyze/judge call armed it — an intuitive "enable -> wait -> read once" sequence read an empty past window and returned insufficient_samples (a dead-end that reads like "the visual is static"). Arm on enable so the ring starts filling immediately; the wait after enabling now accumulates frames. Verified: set_perception_enabled(true) -> wait 2s -> a single analyze_output(av) returns status:ok with ~35 samples (was insufficient_samples). Control-handler only, no new method -> MCP parity unaffected. Full ctest 99/99. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QB6eSNJE55ru3g4vsL77GT
jeffcrouse
enabled auto-merge (squash)
August 11, 2026 14:00
Contributor
Production gate (core): ✅ PASS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reactivity ring only samples while "armed" (
arm()sets an 8s window thatdue()gatespush()on). Enabling perception flipped the master switch but did not arm, so the ring stayed cold until a later analyze/judge call — an intuitive "enable → wait → read once" sequence read an empty past window and returnedinsufficient_samples(reads like "the visual is static").Fix
Arm on enable so the ring starts filling immediately; the wait after enabling now accumulates frames.
Verification
set_perception_enabled(true)→ wait 2s → a singleanalyze_output(av)returnsstatus:okwith ~35 samples (wasinsufficient_samples). Control-handler only, no new method → MCP parity unaffected. Full ctest 99/99.🤖 Generated with Claude Code
https://claude.ai/code/session_01QB6eSNJE55ru3g4vsL77GT