refactor(ticket-191): extract helpers from get_agent_availability (STARTER-609) - #375
Conversation
There was a problem hiding this comment.
Validator approval after policy checks for exact head bd69f69c67d0e5e866708901e3507277f033cf9d.
Ticket: ticket-191
Correlation ID: local-semcod-koru-pr-375-ticket-191
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Pure behavior-preserving refactor of get_agent_availability (CC 15 → 5) into three focused module-level helpers. Env-override precedence, registry parsing, invalid-entry fallback, and expired-block semantics are preserved in the visible diff. Required checks (onedev/local-verify, standard packs/conformance) all pass; pending 'smoke' check is excluded and non-blocking. Ticket intent and README documentation are consistent with the change.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: f171fe09a90cd59315de70a8b02b87db1158ff89...bd69f69c67d0e5e866708901e3507277f033cf9d
Change digest: 88908485d67b7f0c005edccf72b076d0db4fc16ab030b7f8f0d922d6bec79804
Score: 48/100 (M), estimated 56 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":198,"base_sha":"f171fe09a90cd59315de70a8b02b87db1158ff89","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1},"change_digest":"88908485d67b7f0c005edccf72b076d0db4fc16ab030b7f8f0d922d6bec79804","comparison":"f171fe09a90cd59315de70a8b02b87db1158ff89...bd69f69c67d0e5e866708901e3507277f033cf9d","deletions":25,"file_count":3,"files":["project/ticket-191/README.md","project/ticket-191/intent.json","src/koru/agent_availability.py"],"head_sha":"bd69f69c67d0e5e866708901e3507277f033cf9d","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":56,"within_budget":false},"impact":{"components":["origin","project","src/koru","tests"],"files":["origin/main","project/governance-check.sh","project/ticket-191/README.md","project/ticket-191/intent.json","src/koru/agent_availability.py","tests/test_agent_availability.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":12,"name":"Implement origin","scope":["origin"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":12,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":12,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-191"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-191: refactor(ticket-191): extract helpers from get_agent_availability (STARTER-609)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 56m</text></svg>DECISION D-191-9869
TICKET ticket-191
HEAD_SHA bd69f69c67d0e5e866708901e3507277f033cf9d
CORRELATION_ID local-semcod-koru-pr-375-ticket-191
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / enforce=PASS","standard packs / conformance=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/koru","pull_request":375,"head_sha":"bd69f69c67d0e5e866708901e3507277f033cf9d","base_sha":"f171fe09a90cd59315de70a8b02b87db1158ff89","diff_sha256":"2705be6cfb21ce077e8d63811f397a88d680fdc82e377d9b497b1fe437076e64"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-191/README.md","project/ticket-191/intent.json","src/koru/agent_availability.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"f171fe09a90cd59315de70a8b02b87db1158ff89","head_sha":"bd69f69c67d0e5e866708901e3507277f033cf9d","change_digest":"88908485d67b7f0c005edccf72b076d0db4fc16ab030b7f8f0d922d6bec79804","score":48,"complexity":"M","estimated_minutes":56,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Reduce cyclomatic complexity of
get_agent_availabilityfrom CC=15 (limit 15) by extracting behavior-preserving module-level helpers (_environment_override,_availability_from_registry_entry,_with_expired_block_reset).tests/test_agent_availability.pypasses unmodified (7 passed).ruff checkpasses;project/governance-check.sh --base origin/main= GOV-PASS.