fix: set zip date to 1980-01-02, fix CI and test feature gating - #488
Merged
andrius-puksta-sensmetry merged 1 commit intoAug 4, 2026
Merged
Conversation
andrius-puksta-sensmetry
force-pushed
the
pr/newer-timestamp
branch
from
August 4, 2026 06:30
e110b4b to
d61e1be
Compare
Collaborator
|
Hmmm, 2026-01-01 could be indicative of a real date - while 1980 couldn't. What do you think about 1981 or 1980-01-02 instead? |
consideRatio
approved these changes
Aug 4, 2026
consideRatio
left a comment
consideRatio
left a comment
Collaborator
There was a problem hiding this comment.
We can proceed, but I think it is a UX risk to declare 2026 01 01 as it can be confused with an actual date something was set, and for example make people think -- oh this is not updated so recently, instead of thinking "oh this is a dummy date"
andrius-puksta-sensmetry
marked this pull request as draft
August 4, 2026 07:09
andrius-puksta-sensmetry
force-pushed
the
pr/newer-timestamp
branch
4 times, most recently
from
August 4, 2026 08:03
e965b01 to
f5b968f
Compare
andrius-puksta-sensmetry
changed the title
andrius-puksta-sensmetry
force-pushed
the
pr/newer-timestamp
branch
from
August 4, 2026 08:04
f5b968f to
5c44cc2
Compare
andrius-puksta-sensmetry
changed the title
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
andrius-puksta-sensmetry
force-pushed
the
pr/newer-timestamp
branch
from
August 4, 2026 09:24
5c44cc2 to
ef40a3d
Compare
Merged
andrius-puksta-sensmetry
marked this pull request as ready for review
August 4, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo test -p sysand-coredid not work due to references tokeyringcrate. CI was not actuallycargo checking all feature combinations, since due to feature unification (with CLI crate) most features of core were always enabled.