feat: preserve datetime of building the KPAR in the zip metadata - #491
Open
andrius-puksta-sensmetry wants to merge 1 commit into
Open
feat: preserve datetime of building the KPAR in the zip metadata#491andrius-puksta-sensmetry wants to merge 1 commit into
andrius-puksta-sensmetry wants to merge 1 commit into
Conversation
We initialy wanted to make kpars reproducible, so set datetime to earliest possible. To prevent confusion of users who download and unzip a kpar manually (and then see that the files date back to 1980), set the datetime to the build datetime (same for all files). If we find a good reason to have reproducible kpars, this can be changed in the future. Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
consideRatio
approved these changes
Aug 4, 2026
consideRatio
left a comment
consideRatio
left a comment
Collaborator
There was a problem hiding this comment.
I think this is OK to do, not formed a clear opinion yet.
It seems Python wheels built with wheel is letting source file's modified time be respected in the .whl files (zip), but pip when installing a wheel, will install content so its declared modified as "now".
So we have the following considerations:
- What .kpar / zip do we write -- perhaps 1980 / now / last-modified
- What .kpar / zip files do we unpack when using sysand -- perhaps 1980 / now / archive's "modified" info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We initialy wanted to make kpars reproducible, so set datetime to earliest possible (#372). To prevent confusion of users who download and unzip a kpar manually (and then see that the files date back to 1980), set the datetime to the build datetime (same for all files). If we find a good reason to have reproducible kpars, this can be changed in the future.
What do you think @consideRatio? We don't currently have good reasons to do either way, but having the correct time is less confusing to users.