fix(rcdom): inspect descendant node data in get_a_selects_enabled_selectedcontent (closes #776) - #783
Open
rushikeshgarad2024-dev wants to merge 1 commit into
Conversation
…ectedcontent (closes servo#776) - In `Node::get_a_selects_enabled_selectedcontent`, match `&node.data` instead of `&self.data` when iterating through descendant nodes. - Previously, matching `&self.data` tested the parent `<select>` element rather than the descendant node, causing `selectedcontent` lookup to always return `None` and preventing `<option>` cloning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Fix
Resolves #776:
Node::get_a_selects_enabled_selectedcontentinrcdom/lib.rswalked descendant nodes but erroneously matched&self.datainstead of&node.data.Details
selfrefers to the parent<select>element, soname.local_name() == &local_name!("selectedcontent")evaluated to false on every iteration, always returningNone.clone_an_option_into_selectedcontentroutine never ran when parsing customizable selects.&self.datato&node.dataallows<selectedcontent>descendants to be discovered and properly populated with cloned<option>children per WHATWG HTML spec.Closes #776.