Skip to content

Remove Cargo.lock file exception from .gitignore #419

Closed
Closed
Remove Cargo.lock file exception from .gitignore#419

Description

@alejandro-vaz
alejandro-vaz
opened on Aug 20, 2026

As recommended by rust-lang/cargo#12382.

Lockfiles should be committed even in libraries.

Affects v1 and v2 branch.

Activity

  1. alejandro-vaz
    closed this as completedon Aug 20, 2026
  2. alejandro-vaz
    reopened this on Aug 20, 2026

  3. alejandro-vaz commented on Aug 20, 2026

    @alejandro-vaz
    alejandro-vaz
    on Aug 20, 2026
    CollaboratorAuthor

    v2 in #421

  4. alejandro-vaz commented on Aug 20, 2026

    @alejandro-vaz
    alejandro-vaz
    on Aug 20, 2026
    CollaboratorAuthor

    v1 won't implement this due to Cargo.lock version incompatibility

    v2 is safe, lockfile v4 was made the default in 1.83

    can't be implemented into v1 because it breaks the CI workflow

  5. alejandro-vaz
    closed this as completedon Aug 20, 2026
  6. alejandro-vaz
    reopened this on Aug 20, 2026

  7. alejandro-vaz commented on Aug 21, 2026

    @alejandro-vaz
    alejandro-vaz
    on Aug 21, 2026
    CollaboratorAuthor

    merged

  8. alejandro-vaz
    closed this as completedon Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions