Repository navigation
feat: add dark mode to servo.org site - #341
MunishMummadi wants to merge 8 commits into
Conversation
Signed-off-by: Munish Mummadi <moneymindedmunish1@gmail.com>
Signed-off-by: Munish Mummadi <moneymindedmunish1@gmail.com>
cleanup feat: dedicated inverse text tokens for rendering text Signed-off-by: Munish Mummadi <moneymindedmunish1@gmail.com>
|
Thanks for the patch. From the screenshots, I think we need a better solution for the sponsors, maybe having a white background anyway in that section is the simplest one. Other than that I'll defer to @ststimac to review this. |
|
@mrego updated things. Apologies for the delay. Stuck with work! Sponsers
Header
|
ststimac
left a comment
ststimac
left a comment
There was a problem hiding this comment.
A few inline comments about color updates for accessibility purposes.
Additionally, please check
- WPT Pass Rate page (table rows)
- Made with Servo page (check project thumbnail hovers)
- Sponsorship page (table columns)
As there are some elements that need to be adjusted because the text isn't legible (light text on light background)
| --color-primary-hover: #5eead4; | ||
| --color-accent: #14b8a6; | ||
|
|
||
| --bg-page: #0f141c; |
There was a problem hiding this comment.
Let's change this to a darker teal color hex #002a29
|
@MunishMummadi I've added some comments and few other pages that need some styles in dark mode. Sorry this took so long to review. |
|
@ststimac Mind throwing one more look at it? I believe I addressed most/all issues raised! |
|
Just a few more comments left. Thanks! |
|
@ststimac Can I get a fresh pair of eyes? |
Description:
Note: Apologies for the sizing of the images.
Fixes: #206
