Pro: show hero copy in every Pro status, not just never-subscribed and fromCTA - #1978
Merged
Bilb merged 1 commit intoAug 16, 2026
Merged
Conversation
mpretty-cyro
changed the title
mpretty-cyro
force-pushed
the
feature/pro-settings-hero-copy
branch
from
August 13, 2026 04:18
2f77d0f to
95575e0
Compare
…ed and fromCTA The Pro settings hero rendered heroText only for never-subscribed users, and for expired users arriving from a CTA. Expired users reaching the page any other way, and active subscribers, saw the image with nothing under it. Pick the token from the status alone; active gets the new proThanksForSupporting. noColors keeps its own (proExpired && !fromCTA) test, so the greyed-out expired hero is unchanged. Bumps ts/localization to e2f30c5, which is where the three strings landed from Crowdin — without it proThanksForSupporting is not in the token union and this does not typecheck.
mpretty-cyro
force-pushed
the
feature/pro-settings-hero-copy
branch
from
August 13, 2026 04:39
95575e0 to
59ea07e
Compare
Bilb
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pro settings hero rendered heroText only for never-subscribed users, and for expired users arriving from a CTA. Expired users reaching the page any other way, and active subscribers, saw the image with nothing under it.
Pick the token from the status alone; active gets the new proThanksForSupporting. noColors keeps its own (proExpired && !fromCTA) test, so the greyed-out expired hero is unchanged.
Bumps ts/localization to e2f30c5, which is where the three strings landed from Crowdin — without it proThanksForSupporting is not in the token union and this does not typecheck.