Drop EOL Python compatability#158
Open
Teque5 wants to merge 4 commits into
Open
Conversation
* Why do this? * python 3.7, 3.8, 3.9 are all EOL * jsonschema requires Python >= 3.10 * Simpler code * fewer imports * more readable * increment to v3.12.0
* fix typing related to str & Path * fix missing "| None" typing not possible before min version was 3.10 * remaining mypy issues related mypy being unable to 'prove' types fixes require making the codebase more ugly or adding ignore statements in many locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted on this page python versions prior to 3.10 are already end-of-life.
By dropping support for these versions we can use more modern typing and make the code more robust. We are already actually pinned to 3.10 because the minimum version for jsonschema right now is already 3.10. You will discover this if you try to make a new 3.7 environment and try to install
sigmf. Conda-forge recognized this for us and already had the minimum version for sigmf set to 3.10.This will increment version to
v1.12.0.