Update to version 7.* of SIL.Chorus.Mercurial (7.01 current, 7.2.2 upcoming) - #396
Open
rmunn wants to merge 1 commit into
Open
Update to version 7.* of SIL.Chorus.Mercurial (7.01 current, 7.2.2 upcoming)#396rmunn wants to merge 1 commit into
rmunn wants to merge 1 commit into
Conversation
We specify `7.*` instead of `7.0.*` because there is currently an open PR updating SIL.Chorus.Mercurial to version 7.2.2, and a `7.*` spec will allow downstream Chorus-using projects to smoothly update to version 7.2.2 of Mercurial later without requiring a new Chorus PR to be tested and approved.
Contributor
Author
|
I have downloaded the SIL.Chorus.Mercurial 7.0.1.58 NuGet package and run the Chorus unit tests against it, on both Linux and Windows. All tests pass. I have not yet built the Chorus installer and verified that it would work without changes in FLExBridge. That was a concern raised by @hahn-kev in sillsdev/Mercurial4Chorus#30 (review), so it's worth testing. (By someone who has a working setup to build the Chorus installer and test it with FLExBridge and FieldWorks, i.e. not me). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 7.0.1 of SIL.Chorus.Mercurial has been released, and tested to work on both Windows and Linux with no Chorus code changes needed (all unit tests pass). It's time to update the package version that Chorus depends on, so that downstream projects (like LexBox) that want to update to Mercurial 7.x can do so.
We specify
7.*instead of7.0.*because there is currently an open PR updating SIL.Chorus.Mercurial to version 7.2.2, and a7.*spec will allow downstream Chorus-using projects to smoothly update to version 7.2.2 of Mercurial later without requiring a new Chorus PR to be tested and approved.It would also be possible to say "version 6.5.1.43 or later", i.e.:
Or, to keep allowing all
6.5packages (6.5.1.18 was the first 6.5 package released):That would allow all future SIL.Chorus.Mercurial packages, including
8.xand later which don't exist yet. But it's entirely possible that Mercurial 8 will include breaking changes that would need a corresponding change to SIL.Chorus in order to compile, so it's probably safer to just accept7.*rather than a truly open-ended NuGet package range.This change is