Modernize script deployment CLI - #93
Open
adriaandotcom wants to merge 3 commits into
Open
Conversation
adriaandotcom
force-pushed
the
codex/modern-deploy-cli
branch
from
August 4, 2026 10:42
cb86dae to
33f2325
Compare
adriaandotcom
marked this pull request as ready for review
August 4, 2026 10:44
Claude review checkpointReviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #94
Replaces the all-or-nothing Bash
deploy.shwith a standalone TypeScript CLI (deploy.mts, powered by Clack) that drives deployment of the customer-facing tracking scripts to the Bunny CDN and theapp@external.simpleanalytics.comcustom-domain server.Key behavior:
distfiles.Also migrates the repo to pinned Node 24 / pnpm 11 with a strict supply-chain policy (
pnpm-workspace.yaml: seven-day minimum release age, trust checks, exotic-subdep blocking, deny-by-default dependency builds), dropspackage-lock.jsonin favor ofpnpm-lock.yaml, updates the BrowserStack workflow to pnpm, and addstest/deploy.test.mtscovering the manifest, SRI transform, and preview helpers.Changes:
Security implications
Has security impact - described as: changes the deployment path for production, customer-facing tracking scripts (CDN + custom domain), handles Bunny CDN credentials and SSH-based reads/writes to the external server, and introduces a supply-chain policy for dependency installation. Remote paths are validated and shell-quoted before use over SSH, and immutable SRI artifacts are protected against overwrite.
Testing
Not run by Claude. (Automated validation could not be executed in the review sandbox.)
Author-reported validation:
pnpm install --frozen-lockfile— supply-chain policy passedpnpm run typecheckpnpm run test:deploy— 12 tests passedpnpm audit --prod— no known vulnerabilitiesThe intentionally retained legacy test/build dependency graph still has pre-existing audit findings; upgrading that stack is outside this PR.
Checklist