fix: stop the promoted-property picker hiding the key name - #284
Merged
Conversation
The option row let the information-type hint keep its full width and truncated the name instead, so the longest type names left the name with no room at all. Names now get a line of their own, the list narrows to the picked information type, and the JSONPath each key reads is in the row's tooltip.
|
Warning Review limit reachedNext included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: simplify9/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mmalkhatib
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The promoted-property filter on the exchanges page showed its keys like this:
The key name — the only thing you are picking — was squeezed to two characters, or to nothing at all on the rows whose information type has the longest name.
Two causes, both in
SearchSelect:shrink-0and the label wasflex-1 truncate, so the label absorbed 100% of the space loss;w-(--input-width), and this particular filter sits in aw-44slot — 176px for a name plus a 26-character type name.What changed
Names get their own line. New
sublabelonSearchSelectOption, rather than the existingrenderescape hatch, which skips the checkmark and focus styling along with everything else.The list narrows to the picked information type. 14 options to 6 on the test data — and the second line goes away, since repeating the type you just filtered by on every row says nothing.
The hint can no longer starve the label. It shrinks and truncates, capped at half the row. Whatever a hint adds, it is not the half worth keeping when only one of the two fits. This is the part that matters beyond this one page: every other picker in the app had the same latent bug.
The panel may outgrow its input (
min-winstead ofw, capped at 28rem/90vw). 165px to 293px on the property picker.The JSONPath is in the row's tooltip, one line per declaring type:
ShipmentTraceOut: $.account.code. That is what you check when a filter comes back empty and you can't tell whether the key or the value is wrong.Search now matches the second line too, so typing
Inventoryfinds all three of that type's keys.Verified
Reproduced the reported data on the million-row copy — including two keys one character apart (
Account Code,Acoount Code) andInventoryTransactionPostedas the longest type name — then drove the picker in a browser:ShipmentTraceOutacoountAcoount CodeonlyInventoryMovement Type,Sku,Warehouse CodeNo regression in the other pickers: the information-type picker on Subscriptions and Bus gateways still reads
Shipment trace (out)in full alongside its code chip.tscclean,oxlintclean (one pre-existingexhaustive-depswarning, unchanged from base), 76 unit tests pass.🤖 Generated with Claude Code