improvement(cleanup-skill): parallelize analysis, apply fixes sequentially#5609
improvement(cleanup-skill): parallelize analysis, apply fixes sequentially#5609TheodoreSpeaks wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview New The PR also adds several large agent-only command guides (e.g. Reviewed by Cursor Bugbot for commit 3a32a53. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR changes the cleanup workflow to keep parallel analysis while applying edits in order. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (7): Last reviewed commit: "fix(skills): port url-state + comment pa..." | Re-trigger Greptile |
…ing skills into .claude/commands
…ead of literal <scope>
|
@cursor review |
…rough convergence for ordered apply
|
@cursor review |
…e when a prior pass invalidated the snippet
|
@cursor review |
|
@cursor review |
…mbiguate babysit /ship refs in claude copy
|
@cursor review |
…y converge pass-label ordering
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a32a53. Configure here.
| 2. If the `old_string` still matches verbatim, apply it — a content-anchored edit is safe even if its line moved. | ||
| 3. If it no longer matches (an earlier pass altered that region), do **not** force the stale patch. Re-derive the change from the current code by re-applying that pass's rule to the construct, or drop it if a prior pass already made it moot. Never apply a proposal against text it wasn't computed from. | ||
|
|
||
| After all edits, run `bun run lint:check` on the touched files. |
There was a problem hiding this comment.
Lint check cannot target files
Medium Severity
Step 3 tells the orchestrator to run bun run lint:check on the touched files, but the root script is turbo run lint:check with no per-path API. Following the wording literally may pass stray arguments to Turbo or skip lint while believing only edited paths were checked.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 3a32a53. Configure here.


Summary
/cleanupskill to fan out the seven code-quality passes as read-only parallel subagents (fix=false), then converge and apply fixes sequentially in dependency orderType of Change
Testing
Verified all seven sub-skills support the
fix=falsepropose-only pathChecklist