fix(global-commands): use isContentEditable for the editable guard#5623
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview
Tests stub Reviewed by Cursor Bugbot for commit b722f2d. Configure here. |
Greptile SummaryThis PR updates the global shortcut editable guard. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "chore(lint): keep focusable span in edit..." | Re-trigger Greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b722f2d. Configure here.
Summary
element.isContentEditable— the browser's computed editability, which handles focusable descendants of acontenteditableroot,contenteditable="false"islands, invalid attribute values, andplaintext-onlynatively (same approach as Mousetrap/hotkeys-js)isContentEditable(jsdom doesn't implement it) and add a focused-descendant caseType of Change
Testing
Provider tests pass (7/7)
Checklist