Repository navigation
Make FluentValidation tests independent of host culture - #47
Merged
sinanbozkus merged 1 commit intoOct 26, 2026
Merged
Conversation
|
Owner
|
Thanks a lot for the report and the clean fix, @denizumur! Merged. Welcome aboard as a contributor 🎉 |
Contributor
Author
|
Thank you! I really appreciate the review and the warm welcome. Happy to contribute — looking forward to helping again in the future! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Closes #46.
The FluentValidation test suite currently depends on the host machine's UI culture for tests that assert exact English validation messages.
This PR makes those tests deterministic without changing production behavior or FluentValidation localization.
Changes
UseCultureAttributebased on xUnit'sBeforeAfterTestAttributeen-USto test classes that assert exact English validation messagesTestServer.PreserveExecutionContextfor the shared server test host so request execution preserves the selected test cultureMessages_are_localized_by_fluent_validationunchanged so explicit Turkish localization behavior remains coveredValidation
Reproduced under
tr-TRbefore the fix:After the fix:
git diff --checkpassed.NET Core 3.1 builds successfully but could not be executed locally because the .NET Core 3.1 runtime is not installed.
No production code, validation messages, or package references were changed.