Skip to content

Incorrect headers used, leading to problems including missing cookies #124

Description

@UppaJung

Fetching headers from the object is deprecated, and when requestWillBeSentExtraInfo when it is provided, headers should be fetched from there.

Currently, chrome-har gets headers from the response object and generates cookies from it. One consequence of using the wrong headers is that some cookies are missing.

In the existing test suite of JSON files, there are requestWillBeSentExtraInfo header fields that contain cookies that are not present in the response.requestHeaders and response.requestHeaders fields.

I discovered this issue while experimenting with porting/re-writing chrome-har in typescript and trying to replicate chrome-har's current behavior. Please feel free to compare against the typescript implementation to test the fix, or to adopt the code from it, which is also MIT license. (You're free to take the whole thing, but it's a very big change of coding style to adapt to if you don't like typescript.) Sorry that the first you are hearing from me is me filing bugs, but leaving them unreported seemed worse than the alternative.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions