-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/prd 1116 #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/prd 1116 #662
Changes from all commits
773f144
77845fe
64d0bce
44d044c
1b88ac7
ee63398
8e1bbc3
57097bf
7306a1a
55e509b
bc421e3
e28fd3a
3cf246a
1bf1720
d529979
ef16adf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,25 @@ | ||
| ### Added | ||
|
|
||
| - Added JWT token authentication support through `SitumPlugin.setToken()` and the new optional `SitumProvider.token` property. | ||
| - MapView authentication can now be updated at runtime when using JWT token authentication. | ||
| - The most recently updated credential becomes the active authentication method, regardless of whether it is added through a `SitumPlugin` method or via a `SitumProvider` prop. | ||
| ## Changelog | ||
|
|
||
| ### Changed | ||
| ### Added | ||
|
|
||
| - `SitumProvider.apiKey` is now optional. If no credentials are available when the MapView loads, it waits until authentication is provided. | ||
| - Updated the example application React Native from 0.79.1 to 0.83.10 to fix an issue that prevented the app from compiling on iOS. | ||
| - Updated Android example application targetSdkVersion from 35 to 37. | ||
| - Aligned the `react-native-webview` versions in the plugin's `peerDependencies` and the example app so that changes to `react-native-webview` are picked up during testing. | ||
| - Added a `NOTICE` file documenting the plugin's declared native, peer, and | ||
| transitive dependencies, including applicable third-party notices. | ||
| - Included `NOTICE` in the published npm package and preserved it in the iOS | ||
| podspec. | ||
| - Included the root `LICENSE` file in the package published to npm. | ||
|
|
||
| ### Removed | ||
|
|
||
| - Removed routing and navigation bridge between MapView and native SDK as the MapView now always uses its own routing and navigation library. | ||
| - Removed the unused `react-dom` peer dependency from the plugin and the | ||
| unused `react-dom` development dependency from the example application. | ||
| - Removed unused Babel, TypeScript, test, lint, commit, and release tooling | ||
| dependencies from the plugin and example application. | ||
| - Removed the unused `release-it` configuration and dependency from the | ||
| plugin. | ||
| - Removed obsolete commented test imports that referenced | ||
| `jest-mock-extended`. | ||
|
|
||
| ### Fixed | ||
| ### Updated | ||
|
|
||
| - AccessibilityMode documentation now mentions DirectionsOptions instead of DirectionsRequest. | ||
| - Fixed removeNavigationUpdates never resolving when navigation was not running. | ||
| - Fixed navigationRunning remaining active after reaching the destination. | ||
| - Added workaround to TS regression at react-native-webview (https://github.com/react-native-webview/react-native-webview/issues/3977). | ||
| - Updated the React Native CLI and transitive tooling dependencies to resolve | ||
| known vulnerabilities. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,12 @@ | |
| }, | ||
| "resolutions": { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Que é esto?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. E un apartado para fijar versions de dependencias transitivas; para que cando yarn instale, por ejemplo, react-native, e meta as suas propias dependencias (p.e. brace-expansion) pois que instale unha versions sin vulnerabilidades
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Esto entón paréceme peligroso... Si o integrador pode sobrescribir as versións, por que non deixalo da súa man?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ollo, estas resolucions son a nivel de repo porque estou declarando este "resolutions" no package.json raiz.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Entón que utilidade ten o cambio?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Para que a nivel de repo non poidamos meter vulnerabilidades. E dicir, sin estas "resolutions" podriamos estar metendo paquetes comprometidos a hora de desarrollar
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, eu non o teño claro pero si ti o tes claro adiante. |
||
| "@react-native/gradle-plugin": "0.83.10", | ||
| "eslint-plugin-prettier": "^5.4.1" | ||
| "brace-expansion@^1.1.7": "1.1.18", | ||
| "brace-expansion@^2.0.1": "2.1.4", | ||
| "brace-expansion@^5.0.5": "5.0.9", | ||
| "eslint-plugin-prettier": "^5.4.1", | ||
| "fast-xml-parser@^4.0.12": "5.7.0", | ||
| "fast-xml-parser@^4.4.1": "5.7.0" | ||
| }, | ||
| "description": "Situm React Native plugin monorepo.", | ||
| "private": true, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| # Notices for @situm/react-native | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Este texto legal deberia de revisalo Canedo / Angel / Cris / alguen fora de desarrollo ? Preguneille a OpenCode e en teoria non e un texto legal ou xuridico. Simplemente e un texto para cumplir cas indicacions das licencias das nosas dependencias
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplemente revisa o formato do SDK de Android e tira. |
||
|
|
||
| Copyright (c) 2020 - 2026 Situm Technologies | ||
|
|
||
| The plugin source code is licensed under the MIT License. The complete license | ||
| text is provided in the accompanying LICENSE file in the published package. | ||
|
|
||
| ## Declared native dependencies | ||
|
|
||
| | Component | Platform | Version | License or terms | | ||
| | ---------------------------------------------------- | -------- | ---------- | ------------------------------------- | | ||
| | SitumSDK | iOS | 3.40.0 | Applicable Situm terms and conditions | | ||
| | SitumSDK | Android | 3.38.0@aar | Applicable Situm terms and conditions | | ||
| | React Native (`com.facebook.react:react-native`) | Android | matches installed peer | MIT | | ||
| | JTS Topology Suite (`org.locationtech.jts:jts-core`) | Android | 1.16.1 | EDL-1.0 | | ||
|
|
||
| SitumSDK is a separate product of Situm Technologies. The MIT License for this | ||
| plugin does not grant rights to SitumSDK beyond its applicable terms and | ||
| conditions. SitumSDK for Android is resolved transitively; components it may | ||
| pull in are governed by their own respective terms. | ||
|
|
||
| ### JTS Topology Suite | ||
|
|
||
| JTS 1.16.1 is dual-licensed under the Eclipse Public License 1.0 (EPL-1.0) and | ||
| the Eclipse Distribution License 1.0 (EDL-1.0). This distribution uses the | ||
| EDL-1.0 option. | ||
|
|
||
| Source files in JTS 1.16.1 carry the following notice: | ||
|
|
||
| Copyright (c) 2016 Vivid Solutions. | ||
|
|
||
| All rights reserved. This program and the accompanying materials | ||
| are made available under the terms of the Eclipse Public License v1.0 | ||
| and Eclipse Distribution License v. 1.0 which accompanies this distribution. | ||
| The Eclipse Public License is available at | ||
| http://www.eclipse.org/legal/epl-v10.html | ||
| and the Eclipse Distribution License is available at | ||
| http://www.eclipse.org/org/documents/edl-v10.php. | ||
|
|
||
| JTS also includes content sourced from the GeoTools project, licensed to JTS | ||
| under the OSGeo BSD License by the GeoTools PSC. See: | ||
| https://github.com/locationtech/jts/blob/jts-1.16.1/LICENSES.md | ||
|
|
||
| #### Eclipse Distribution License - v 1.0 | ||
|
|
||
| Copyright (c) 2007, Eclipse Foundation, Inc. and its licensors. | ||
|
|
||
| All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without | ||
| modification, are permitted provided that the following conditions are met: | ||
|
|
||
| - Redistributions of source code must retain the above copyright notice, this | ||
| list of conditions and the following disclaimer. | ||
| - Redistributions in binary form must reproduce the above copyright notice, | ||
| this list of conditions and the following disclaimer in the documentation | ||
| and/or other materials provided with the distribution. | ||
| - Neither the name of the Eclipse Foundation, Inc. nor the names of its | ||
| contributors may be used to endorse or promote products derived from this | ||
| software without specific prior written permission. | ||
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE | ||
| LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| ## Peer dependencies | ||
|
|
||
| The following peer dependencies are installed and version-selected by the | ||
| consuming application. They are not bundled in the published npm package. | ||
|
|
||
| | Component | Version range | License | | ||
| | -------------------- | ------------- | ------- | | ||
| | React | >=17.0.0 | MIT | | ||
| | React Native | * | MIT | | ||
| | react-native-webview | >=11.0.0 | MIT | | ||
|
|
||
| React is Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| React Native is Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| react-native-webview is Copyright (c) 2015-present, Facebook, Inc. | ||
| (verify against the LICENSE file of the version you resolve). | ||
|
|
||
| ## Source manifests | ||
|
|
||
| Dependency declarations are maintained in `package.json`, | ||
| `ReactNativeSitumPlugin.podspec`, and `android/build.gradle`. | ||
|
|
||
| Development-only dependencies used to build, test, lint, or release this | ||
| package are not part of the published runtime artifact. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,10 +29,10 @@ | |
| "lib", | ||
| "android", | ||
| "ios", | ||
| "cpp", | ||
| "*.podspec", | ||
| "README.md", | ||
| "LICENSE", | ||
| "NOTICE.md", | ||
| "SECURITY-POLICY.md", | ||
| "security.txt", | ||
| "!lib/typescript/example", | ||
|
|
@@ -53,7 +53,10 @@ | |
| "typescript": "tsc --noEmit", | ||
| "prepare": "yarn bob build; yarn doc", | ||
| "doc": "typedoc --readme ../README.md --out ./docs/types ./src --tsconfig ./tsconfig.json && mkdir -p ./docs/types/docs/assets && cp -r ./docs/assets/* ./docs/types/docs/assets/", | ||
| "clean": "del-cli android/build example/android/build example/android/app/build example/ios/build" | ||
| "clean": "del-cli android/build example/android/build example/android/app/build example/ios/build", | ||
| "verify:licenses": "node scripts/verify-licenses.js", | ||
| "prepack": "cp ../README.md ../LICENSE ../SECURITY-POLICY.md ../security.txt . && bob build && yarn doc && node scripts/verify-pack.js", | ||
| "postpack": "rm README.md LICENSE SECURITY-POLICY.md security.txt" | ||
| }, | ||
| "keywords": [ | ||
| "react-native", | ||
|
|
@@ -66,40 +69,26 @@ | |
| ], | ||
| "devDependencies": { | ||
| "@babel/core": "^7.22.5", | ||
| "@babel/eslint-parser": "^7.22.5", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Porfa revisade que ningun paquete de desarrollo e necesario para desarrollar o plugin. Pedinlle a OpenCode que revisara todas as dependencias que non se estaban a usar no proyecto e quitou todas estas; reviseinas e non boto ningunha en falta
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non entendo que é o que nos pides. Penso que esa revisión é parte da tarefa, non?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplemente un repaso visual de que non estou eliminando ninguna dependencia que sexa importante
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. O analisis das dependencias que eliminei deixeino no ticket |
||
| "@babel/plugin-transform-strict-mode": "^7.25.9", | ||
| "@babel/preset-env": "^7.22.5", | ||
| "@babel/runtime": "^7.22.5", | ||
| "@commitlint/config-conventional": "^17.6.7", | ||
| "@react-native-community/eslint-config": "^3.2.0", | ||
| "@types/jest": "^29.5.3", | ||
| "@types/react": "^18.2.7", | ||
| "@types/react-native": "0.72.2", | ||
|
R-lagoman marked this conversation as resolved.
|
||
| "@types/react-test-renderer": "^18.0.0", | ||
| "commitlint": "^17.6.6", | ||
| "del-cli": "^5.0.0", | ||
| "eslint": "^8.44.0", | ||
| "jest": "^29.5.0", | ||
| "jest-mock-extended": "^3.0.5", | ||
| "metro-react-native-babel-preset": "0.73.7", | ||
| "prettier": "^3.2.4", | ||
| "react-native": "^0.72.12", | ||
| "react-native-builder-bob": "^0.35.0", | ||
| "react-native-webview": ">=11.0.0", | ||
| "react-test-renderer": "18.2.0", | ||
| "release-it": "^16.1.3", | ||
| "typedoc": "^0.28.2", | ||
| "typescript": "^5.5.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": ">=17.0.0", | ||
| "react-dom": ">=17.0.0", | ||
| "react-native": "*", | ||
| "react-native-webview": ">=11.0.0" | ||
| }, | ||
| "resolutions": { | ||
| "@types/react": "19.0.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 16.0.0" | ||
| }, | ||
|
|
@@ -115,11 +104,6 @@ | |
| "<rootDir>/example/" | ||
| ] | ||
| }, | ||
| "commitlint": { | ||
| "extends": [ | ||
| "@commitlint/config-conventional" | ||
| ] | ||
| }, | ||
| "react-native-builder-bob": { | ||
| "source": "src", | ||
| "output": "lib", | ||
|
|
@@ -134,23 +118,6 @@ | |
| ] | ||
| ] | ||
| }, | ||
| "release-it": { | ||
| "git": { | ||
| "commitMessage": "chore: release ${version}", | ||
| "tagName": "v${version}" | ||
| }, | ||
| "npm": { | ||
| "publish": true | ||
| }, | ||
| "github": { | ||
| "release": true | ||
| }, | ||
| "plugins": { | ||
| "@release-it/conventional-changelog": { | ||
| "preset": "angular" | ||
| } | ||
| } | ||
| }, | ||
| "eslintIgnore": [ | ||
| "node_modules/", | ||
| "lib/" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.