Skip to content

chore(infra): remove pg14 parameter group from aws terraform - #3755

Merged
sunghyun1000 merged 1 commit into
mainfrom
chore/remove-pg14-prameter-group
Sep 11, 2026
Merged

chore(infra): remove pg14 parameter group from aws terraform#3755
sunghyun1000 merged 1 commit into
mainfrom
chore/remove-pg14-prameter-group

Conversation

@sunghyun1000

@sunghyun1000 sunghyun1000 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Description

blue db 삭제 후 불필요해진 postgres14의 파라미터 그룹을 삭제했습니다.

Additional context

terraform plan을 실행하고 변경사항 없음이 뜨는 것을 확인 완료 하였습니다.


Before submitting the PR, please make sure you do the following

Summary by CodeRabbit

  • Chores
    • Removed the unused PostgreSQL 14 logical replication parameter group configuration.

@sunghyun1000 sunghyun1000 self-assigned this Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 462a6d7b-8f52-4b73-9ec9-f3d7250b8ee1

📥 Commits

Reviewing files that changed from the base of the PR and between 13779c1 and 38d98d3.

📒 Files selected for processing (1)
  • infra/aws/storage/database.tf
💤 Files with no reviewable changes (1)
  • infra/aws/storage/database.tf

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The AWS storage configuration removes the PostgreSQL 14 logical replication parameter group. The PostgreSQL 18 parameter group and database instance configuration remain unchanged.

Changes

Database configuration

Layer / File(s) Summary
Remove PostgreSQL 14 parameter group
infra/aws/storage/database.tf
Removes the postgres14_logical parameter group and its logical replication settings. The postgres18 parameter group remains assigned to the database instance.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 38d98

This cleanup should not affect the active database configuration and is ready to merge.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The pull request removes an AWS Terraform parameter group, but linked issue #123 requires a frontend progress card component. The linked issue objectives are not implemented. Implement the progress card component described in issue #123, or link the pull request to an issue that covers removal of the unused PostgreSQL 14 parameter group.
Out of Scope Changes check ⚠️ Warning The infrastructure change is unrelated to the directly linked frontend progress card issue #123. Remove the infrastructure change from this pull request, or update the linked issue to reflect the AWS Terraform cleanup objective.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the PostgreSQL 14 parameter group from AWS Terraform.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

🤖 Coding task started

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-pg14-prameter-group

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

⚠️ Coding task failed

The task could not be completed. Open the task for details or retry.

@sunghyun1000
sunghyun1000 requested a review from rla120 September 11, 2026 09:46

@rla120 rla120 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunghyun1000
sunghyun1000 added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 5507cd0 Sep 11, 2026
33 checks passed
@sunghyun1000
sunghyun1000 deleted the chore/remove-pg14-prameter-group branch September 11, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants