Skip to content

feat(fe): adds section column to course list table - #3759

Merged
egg-zz merged 1 commit into
mainfrom
t2991-add-class-column-to-table
Sep 13, 2026
Merged

feat(fe): adds section column to course list table#3759
egg-zz merged 1 commit into
mainfrom
t2991-add-class-column-to-table

Conversation

@egg-zz

@egg-zz egg-zz commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Description

교수님 요청사항
admin/course 페이지에 분반 column 추가

Additional context

datatableheader는 글자 크기 통일을 위 text-base만 추가했습니다~

closes TAS-2991


Before submitting the PR, please make sure you do the following

Summary by CodeRabbit

  • New Features

    • Added a non-sortable Section column to the course administration table.
    • Displays the section number when available, or - when no section is assigned.
  • UI Improvements

    • Increased the text size of unsortable column headers while preserving their existing alignment and styling.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f187e39b-540a-4f76-8666-bb00adb0aaf7

📥 Commits

Reviewing files that changed from the base of the PR and between 23f2970 and 1bfc0e6.

📒 Files selected for processing (3)
  • apps/frontend/app/admin/_components/table/DataTableColumnHeader.tsx
  • apps/frontend/app/admin/course/_components/Columns.tsx
  • apps/frontend/app/admin/course/_components/GroupTable.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The course table now displays a non-sortable Section column. Course section values are nullable and display - when absent. Unsortable column headers use the text-base class.

Changes

Course section column

Layer / File(s) Summary
Section data and presentation
apps/frontend/app/admin/course/_components/Columns.tsx, apps/frontend/app/admin/course/_components/GroupTable.tsx, apps/frontend/app/admin/_components/table/DataTableColumnHeader.tsx
DataTableCourse.classNum accepts number or null. GroupTable supplies the value from courseInfo. The columns definition renders a non-sortable Section column and uses - for null values. Unsortable headers use text-base styling.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 1bfc0

The course table displays section values or a dash when absent, with no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #123 requires a progress card component for workbook progress. The component must support title, header, description, type, total, and complete. The reviewed changes only update the … Implement the ProgressCard component required by #123 with the specified properties and add focused automated tests for its rendered content and progress values.
Out of Scope Changes check ⚠️ Warning The new Section column, nullable classNum handling, and text-base styling address the course administration table. These changes have no demonstrated connection to the progress card requirement … Remove these unrelated changes from this pull request, or link them to the appropriate course-table issue and submit the progress card work separately.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: adding a Section column to the course list table.
Full details: Linked Issues check

Explanation

Issue #123 requires a progress card component for workbook progress. The component must support title, header, description, type, total, and complete. The reviewed changes only update the course table and DataTableColumnHeader; they do not add the required component or related automated tests.

Full details: Out of Scope Changes check

Explanation

The new Section column, nullable classNum handling, and text-base styling address the course administration table. These changes have no demonstrated connection to the progress card requirement in #123.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t2991-add-class-column-to-table

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@egg-zz egg-zz self-assigned this Sep 13, 2026
@egg-zz egg-zz added ⛳️ team-frontend preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 labels Sep 13, 2026
@skkuding-bot

skkuding-bot Bot commented Sep 13, 2026

Copy link
Copy Markdown

Syncing Preview App Failed

Application: frontend
Revision: 1bfc0e6cb029732f969282c9ee1a0cc45858c3cb
Health Status: Degraded

Open Preview | View in Argo CD

@howso245-dot howso245-dot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 수고하셨습니다

@egg-zz
egg-zz added this pull request to the merge queue Sep 13, 2026
Merged via the queue into main with commit 0f67dfb Sep 13, 2026
48 of 49 checks passed
@egg-zz
egg-zz deleted the t2991-add-class-column-to-table branch September 13, 2026 12:32
@skkuding-bot skkuding-bot Bot removed the preview 이 라벨이 붙어있어야 프론트엔드 Preview 환경이 생성됩니다 label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants