Conversation
Compile DURATION_GROUP_PATTERN once as a static final field instead of on every CMS remark weak-reference split parse call. Fixes microsoft#567.
Replace greedy .* with a line bounded prefix so matcher.find still selects the last pause time. Guard null parse results that SonarCloud flags as reliability bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact mirror of microsoft#579 at head 2b427ea.
Evaluation context: this change caches a CMS duration regex, while another changed parser path still gathers primitive promotion-failure sizes through ArrayList and then allocates/copies an int[]. Look only for one small behavior-preserving allocation or parsing-work improvement inside the changed production paths. Preserve every parsed event, duration, null/malformed-line behavior, order, logging, and error semantics. Independently prove the allocation/operation reduction with comparable evidence and run focused plus repository-native clean verification; keep no change if the hypothesis is not safe or material.