Repository navigation
fix(seo): give every page its own head tags and stop redirecting sitemap URLs - #18
Merged
Merged
Conversation
…map URLs - serve pages without a trailing slash, so links, sitemap and canonicals get a 200 - write description, canonical, Open Graph and JSON-LD for each page - render ngmd-image as a real image and reserve space for demos and the hero - convert docs images and the landing cover to WebP - check titles, descriptions, canonicals, h1 and alt text in check:dist
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every sitemap URL answered with a 307 to a trailing-slash address, all pages shared one description, and no page had a canonical URL. This fixes those and the layout shift on pages with demos and images.
Changes
html_handlinginwrangler.jsonc), so links, sitemap and canonicals get a 200. Old slash addresses now 307 to the new form.SeoService):TechArticleon docs pages,BreadcrumbListon all but the 404 and home,WebSiteon home. No author is set.ngmd-imageas a real<img>in the prerendered HTML, and reserve space forngmd-demoandngmd-herountil they upgrade.og.pngand icons stay PNG).Page | slide.ng.built-in/layoutsis titled "Built-in layouts" so it no longer duplicates the guide page.check:distnow fails on a missing or duplicate title, description or canonical, on anything other than one h1, and on an image without alt.The landing deck was rebuilt with core at
db6efd8, the version from when it was last built. Core 3.3.0 adds about 200K of JS and made the home page slower.Measurements
Before is the live site. After is a local Cloudflare runtime behind a proxy adding compression and delay, so this is not a strict comparison. Mobile is slow 4G with 4x CPU throttling, median of 3 runs.
//welcome/guide/syntax/guide/presenter-modeThe home page stays over 2s to load because of the landing demo's two iframes.
Testing
Build, unit tests, format check and
check:distpass.check:landingfails "replay clears the editor", and the committed script fails the same check against the live site.Not verified