-
Notifications
You must be signed in to change notification settings - Fork 20
feat(guide): memory_save 指引补 scope 声明规则(#249 第二批) #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
modusensus
merged 2 commits into
slow-stack:main
from
heptaspirit:feat/249-scope-guidance
Oct 2, 2026
+46
−2
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: slow-stack/mneme
Length of output: 14719
🏁 Script executed:
Repository: slow-stack/mneme
Length of output: 30193
区分省略参数与最终未标注记录。
scopeEnabled和strictScope的默认值都是false。在默认配置下,省略两个参数会保留为未标注记录,并且处处可见。当
scopeEnabled开启且会话 scope 可解析时,省略参数会由memory_save.execute自动填入会话 scope。该记录不是未标注记录。在其他 scope 下,自动标注记录可能被降权;显式标注的记录还可能被过滤。当前两句没有说明这个条件。请在
dsh-mneme/src/guide.js和同步文件dsh-mneme/lib/guide.js中明确区分省略参数与最终未标注记录。建议修正
📝 Committable suggestion
🤖 Prompt for AI Agents