Skip to content

fix: the hosted app pages follow the app, search leaves decision records out, and code runs wider than prose - #32

Merged
robbeverhelst merged 1 commit into
mainfrom
review-fixes-wave1
Oct 1, 2026
Merged

robbeverhelst merged 1 commit into
mainfrom
review-fixes-wave1

Conversation

@robbeverhelst

Copy link
Copy Markdown
Contributor

Five findings from the docs review of 2026-10-01, each checked against the app's main and the live console before it was changed. All five held.

What is kept, and for how long

Three pages said "nothing is deleted". The app deletes history past the plan every night.

  • Plans: history past the plan is deleted each night, and a bigger plan does not bring deleted lines back. A plan that ends or narrows keeps its wider history for 30 days, then the older lines are deleted.
  • What the app keeps: a new section, "How long it keeps it", with every window in one list, and links to the terms and the privacy policy. A repo that leaves the installation is kept 30 days, then deleted. "If you stop using the app" now says an uninstall is deleted after 30 days and names Delete everything.

The wording matches sluiceway.dev/terms and sluiceway.dev/privacy as published today.

Using the app and Plans follow the console

Corrected line by line (A6 to A23 of the review):

  • A session lasts 30 days and access is checked again every hour, not eight hours.
  • An Overview row says how the last deploy ended and who, not the commit and the run.
  • The app draws with the action release it carries, which can be older than these docs.
  • Rescan is only drawn where the app can scan. Other repos are "Rescan on GitHub" in the org's menu.
  • Insights cover 12 weeks, 6 months or 1 year, as far as the plan's history goes.
  • The audit log: the flag is "⚠ outside the dashboard" in bold, the filters are buttons, there is no stack button, the button reads Download CSV, and the log reads a month at a time.
  • Edit mode: the settings per block, the layout keys, and ignore under In sync.
  • The Minimal template never redacted. The page now says what it sets, and that no template turns redact on.
  • There is no Save: Review pull request, then Open the pull request. The old heading's address redirects.
  • Settings: The app's access, Second approver and Delete everything.
  • Plans: a repo past the plan has a page, and a promotion code is for the monthly price.
  • Get started: a tick in the console holds five seconds for Undo.

Search leaves the decision records out

The review asked to weigh the records down. That does not work in Pagefind 1.5: a match in a page's title is boosted apart from the weight of its words, and scores saturate, so a record at 1/24 of the weight still led "drift". The records are left out of the index instead. The list of records stays in, so "decision records" or a record's number finds it, and search engines still index every record.

Query First three before First three now
tick three records Overview, Using the app, Security
drift three records Configuration, sluiceway.yaml, What it looks like
destroy three records Command line, sluiceway.yaml, Glossary
credentials two records in the first three Credentials first

Two queries of the review are not fixed by this: "cli" (the Command line page never says the word) and "github app" (Install the app is not in the first five).

Code runs wider than prose

Prose keeps 54ch. The column is 86ch, and code blocks and tables take all of it: 712px at 1340 wide, where it was 541px.

Width Code blocks that scroll sideways, before Now
1340 96 of 217 71
1720 96 54

The 71 left have lines longer than any column (JSON, quoted messages). Wrapping them is a separate choice and is not made here. On Run the action yourself the nine comment lines read whole at 1340; one line, the cron comment, is 25px over.

Run the action yourself

The workflow file comes first, then Requirements, then the README's steps as four numbered headings, with "When the first scan is red" after them. Each step is in "On this page". The loader reads the README's bold openings and stops the build when that shape changes.

The permissions table

Left as it is, with one sentence above it: the table is being corrected, and follows what GitHub shows on a real install.

Checks

bun run check, and the build, bun run links and bun test at both addresses: 726 tests pass, 33,673 links land. New tests: search.test.ts asks the built Pagefind index, hosted-app.test.ts holds each corrected sentence, self-run-steps.test.ts and code-width.test.ts. No page scrolls sideways at 1340 or 390.

🤖 Generated with Claude Code

… shows, search leaves the records out, code runs wider than prose, and the self-run steps are numbered

From the docs review of 2026-10-01. Each finding was checked against the
app's main and the live console before it was changed.

- What is kept: three pages said nothing is deleted. History past the
  plan is deleted each night, a plan that narrows keeps its wider history
  30 days, and a repo or an installation that goes is kept 30 days, as the
  published terms and privacy policy say. What the app keeps has a section
  for it, and names Delete everything.
- Using the app and Plans follow the console: a session of 30 days checked
  every hour, what an Overview row says, the Insights window, the audit
  log's buttons and Download CSV, edit mode's blocks, the Minimal template
  (it never redacted), Review pull request, The app's access, the page of a
  repo past the plan, and promotion codes on the monthly price only.
- Search: decision records are left out of the Pagefind index. Weighing
  them down does not work in Pagefind 1.5, where a title match is boosted
  apart from a page's weight. The list of records stays in the index.
- Code blocks and tables take a column of 86ch, and prose keeps 54ch.
- Run the action yourself shows the workflow file first, then the README's
  steps as numbered headings, with the red first scan after them.
- Install the app says its permissions table is being corrected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robbeverhelst
robbeverhelst merged commit 5c93984 into main Oct 1, 2026
4 checks passed
@robbeverhelst
robbeverhelst deleted the review-fixes-wave1 branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant