fix: TTS truncation (#115) + publish_and_wait race (#116) + realtime integration test - #121
Merged
Merged
Conversation
…realtime integration test - WavesStreamingTTS raises on a pre-complete socket close instead of silently returning truncated audio (routes the drop to error_queue, which every consume loop already checks). issue #115. - Versioning.publish_and_wait captures the pre-publish newest revision as a baseline so wait_for_commit does not match the stale previously-published one. issue #116. - Add a live-gated (SMALLEST_API_KEY, -m integration) realtime integration test: mint a register-call token, open the documented wss URL, assert the session comes up and the agent produces a spoken turn. - Bump to 5.12.2.
|
crim doesn't review pull requests automatically here. Comment |
…nt Tools/Secrets helpers in README - asyncio.timeout is 3.11+, but the package targets python ^3.9; switch the frame collector to asyncio.wait_for so the live test runs on 3.9/3.10 too. - README had no Tools/Secrets section (shipped in 5.12.0/5.12.1); add one with the registry create/list/duplicate/delete flow and the toolRefs note.
…covers md code blocks)
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two open issues, both hand-written helper bugs with the repros they shipped:
WavesStreamingTTSreturned truncated audio as if complete when the socket dropped beforecomplete(sharedNonesentinel). Now routes a pre-complete close toerror_queue, so every consume loop raisesConnectionError; audio already received is still yielded first.Versioning.publish_and_waitcould return the previous already-published revision during the window before the new one surfaces. Now captures the pre-publish newest revision id as a baseline and waits for a different one.Also adds the integration test that was missing: a live-gated (
SMALLEST_API_KEY,-m integration) realtime test that mints a register-call token, opens the documented wss URL, and assertssession.createdplus the agent's spoken turn (output_audio.delta). Verified live on a Pay-As-You-Go account.Bumps to 5.12.2. mypy clean, ruff clean, 14 TTS/versioning unit tests pass.
Note: a companion CI change (run on
pull_requestso fork PRs get checked) is needed but could not be pushed from here (token lacksworkflowscope) — applying separately.