chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoff to CRESettings - #2344
Conversation
|
👋 vreff, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
There was a problem hiding this comment.
Pull request overview
This PR extends the CRE settings schema to expose two new Confidential Compute configuration knobs related to public-key retrieval retry behavior, and wires them through the default config artifacts and documentation.
Changes:
- Add
ConfidentialCompute.MaxPublicKeyRetriesandConfidentialCompute.MaxPublicKeyRetriesBackoffSecondsto the Go settings schema and defaults. - Update
defaults.tomlanddefaults.jsongolden defaults to include the new keys. - Update the CRE settings README mermaid diagram to reflect the new settings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Adds new schema fields and default values under ConfidentialCompute. |
| pkg/settings/cresettings/README.md | Updates the mermaid diagram to include the new settings nodes. |
| pkg/settings/cresettings/defaults.toml | Adds default values for the new settings in TOML. |
| pkg/settings/cresettings/defaults.json | Adds default values for the new settings in JSON. |
Suppressed comments (1)
pkg/settings/cresettings/settings.go:591
- Consider making MaxPublicKeyRetriesBackoffSeconds a Setting[time.Duration] (like the other timeout/backoff fields) rather than Setting[int] with a custom unit tag. This keeps units consistent ("s") and prevents ambiguity about whether the value is seconds vs. some other duration base.
InsecureSkipTLSVerify Setting[bool]
EnclaveRefreshInterval Setting[time.Duration]
MaxPublicKeyRetries Setting[int] `unit:"{attempt}"`
MaxPublicKeyRetriesBackoffSeconds Setting[int] `unit:"{second}"`
PublicKeyCache ccPublicKeyCache
Session ccSession
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
No description provided.