Skip to content

chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoff to CRESettings - #2344

Merged
justinkaseman merged 9 commits into
mainfrom
add-settings
Aug 26, 2026
Merged

chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoff to CRESettings#2344
justinkaseman merged 9 commits into
mainfrom
add-settings

Conversation

@vreff

@vreff vreff commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vreff
vreff requested a review from a team as a code owner August 26, 2026 17:19
Copilot AI lite review requested due to automatic review settings August 26, 2026 17:19
@vreff vreff changed the title chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoffSeconds … chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoffSeconds to CRESettings Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 vreff, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (2)

pkg/settings/cresettings.confidentialCompute (2)
  • PublicKeyRetriesBackoff — ➕ Added

  • PublicKeyRetriesMax — ➕ Added


📄 View full apidiff report

@vreff
vreff requested review from jmank88 and pavel-raykov August 26, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the CRE settings schema to expose two new Confidential Compute configuration knobs related to public-key retrieval retry behavior, and wires them through the default config artifacts and documentation.

Changes:

  • Add ConfidentialCompute.MaxPublicKeyRetries and ConfidentialCompute.MaxPublicKeyRetriesBackoffSeconds to the Go settings schema and defaults.
  • Update defaults.toml and defaults.json golden defaults to include the new keys.
  • Update the CRE settings README mermaid diagram to reflect the new settings.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
pkg/settings/cresettings/settings.go Adds new schema fields and default values under ConfidentialCompute.
pkg/settings/cresettings/README.md Updates the mermaid diagram to include the new settings nodes.
pkg/settings/cresettings/defaults.toml Adds default values for the new settings in TOML.
pkg/settings/cresettings/defaults.json Adds default values for the new settings in JSON.
Suppressed comments (1)

pkg/settings/cresettings/settings.go:591

  • Consider making MaxPublicKeyRetriesBackoffSeconds a Setting[time.Duration] (like the other timeout/backoff fields) rather than Setting[int] with a custom unit tag. This keeps units consistent ("s") and prevents ambiguity about whether the value is seconds vs. some other duration base.
	InsecureSkipTLSVerify             Setting[bool]
	EnclaveRefreshInterval            Setting[time.Duration]
	MaxPublicKeyRetries               Setting[int] `unit:"{attempt}"`
	MaxPublicKeyRetriesBackoffSeconds Setting[int] `unit:"{second}"`
	PublicKeyCache                    ccPublicKeyCache
	Session                           ccSession

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/settings/cresettings/settings.go Outdated
Comment thread pkg/settings/cresettings/defaults.toml Outdated
Comment thread pkg/settings/cresettings/defaults.json Outdated
Comment thread pkg/settings/cresettings/README.md Outdated
vreff and others added 5 commits August 26, 2026 13:23
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vreff vreff changed the title chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoffSeconds to CRESettings chore: add MaxPublicKeyRetries and MaxPublicKeyRetriesBackoff to CRESettings Aug 26, 2026
Comment thread pkg/settings/cresettings/settings.go Outdated
@justinkaseman
justinkaseman added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit c1aa3d0 Aug 26, 2026
31 of 32 checks passed
@justinkaseman
justinkaseman deleted the add-settings branch August 26, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants