Skip to content

Nightly audit 2026-11-07/08: AGENTS docs, dead helpers, mouse comments, picker rustdoc - #294

Draft
smarzban wants to merge 2 commits into
mainfrom
feat/nightly-audit-2026-11-07-cede
Draft

smarzban wants to merge 2 commits into
mainfrom
feat/nightly-audit-2026-11-07-cede

Conversation

@smarzban

@smarzban smarzban commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Nightly Engineer audit for 2026-11-07 (slices A–C) plus 2026-11-08 leftover, rebased onto main @ 36610e8f (#295 project titles). Draft only; never merge.

  • A. AGENTS.md: HERDR_ENV=1 means inside Herdr (HostKind::Herdr), not outside. DispatchHost row notes Rex; setup row adds tsk setup rex (src/setup/rex.rs, src/setup/rex.lua).
  • B. Deleted unused CleanupRow::merge_skip_reason and BoardModel::chrome_row_is_plain after repo-wide search found only definitions. Left pr_line, open_field_edit, edit_target.
  • C. Fixed stale shrink-collapse comments on mouse_intent_target / board_mouse_intent: resolve_board_surface only returns the model's input mode. Left past-tense notes and the motion gate.
  • 2026-11-08 leftover. After Project titles: display name per project, accepted by -p (T459, #249) #295, put the three-line picker rustdoc back on paint_scope_dropdown and delete the stranded #[allow(clippy::too_many_arguments)] above PROJECT_TITLE_EDIT_FOOTER (footer keeps its one-line const doc). src/ui/render.rs only; ScopeDropdownPaint untouched.

Avoided #271 surfaces (dispatch.rs, agents.rs, store.rs, queue.rs). No changelog. No skill bump. Kept capture.rs and DocumentGateway Default.

Test plan

  • GIT_CONFIG_GLOBAL=/dev/null cargo fmt --check
  • GIT_CONFIG_GLOBAL=/dev/null cargo clippy --all-targets -- -D warnings
  • GIT_CONFIG_GLOBAL=/dev/null cargo test — lib green; integration: known git_base::two_tsk_processes… flake + golden project_picker_110x30 day-count drift (1088d→1089d) also fails without this PR’s render.rs change
  • Manual herdr open-board smoke — N/A (docs/comments/dead code only; HERDR_ENV unset)
  • cd site && npm ci && npm test && npm run build — N/A
Open in Web Open in Cursor 

@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
herdr-tsk Ignored Ignored Preview Nov 8, 2026 2:23am UTC

cursoragent and others added 2 commits November 8, 2026 02:20
Correct HERDR_ENV=1 as inside Herdr, note Rex on DispatchHost and setup
rex paths, delete unused merge_skip_reason and chrome_row_is_plain, and
fix resolve_board_surface shrink-collapse comments that no longer match.

Co-authored-by: Saeed <smarzban@users.noreply.github.com>
#295 left the picker rustdoc and a stranded clippy allow above
PROJECT_TITLE_EDIT_FOOTER. Put the three-line doc back on the fn and
keep the footer's one-line const doc.

Co-authored-by: Saeed <smarzban@users.noreply.github.com>
@cursor
cursor Bot force-pushed the feat/nightly-audit-2026-11-07-cede branch from 4957e4e to ba56ab3 Compare November 8, 2026 02:23
@cursor cursor Bot changed the title Nightly audit 2026-11-07: AGENTS host docs, dead helpers, mouse comments Nightly audit 2026-11-07/08: AGENTS docs, dead helpers, mouse comments, picker rustdoc Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants