Fix #248: support inline AsyncAPI message payloads and align custom validator packages (6.7.4) - #413
Open
joseegman wants to merge 1 commit into
Conversation
…ustom validator packages (6.7.4)
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 37 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Fix del bug reportado en #248 ([ASYNCAPI] Custom validators bug): cuando un mensaje AsyncAPI tiene un payload inline (mapa de propiedades con
$refsin declarartype/properties, como elCreateOrderEventdel spec adjunto a la issue), el generador crasheaba con unFreeMarkererror al procesarCreateOrderEventDTOporque un campo quedaba conbaseNamenulo.Además, se verifica que los custom validators generados quedan alineados con su package: el test de regresión comprueba que cada
.javagenerado declara unpackageque coincide con su estructura de carpetas.Cambios
ApiTool.isInlineObject: detección de schemas inline (objeto sintype/properties/$ref/combinadores) cuyo contenido son campos de negocio.ModelBuilder.getFields: los schemas inline se procesan ahora como propiedades (schema.fields()) en lugar de caer en la rama final que generaba unSchemaFieldObjectsinbaseName.TestIssue248CustomValidators: usa el spec realevent-api.ymlde la issue [ASYNCAPI] Custom validators bug #248 y valida que todos los archivos generados (DTOs, consumer, producer y custom validators) declaran el package correcto según su ruta.Verificación
multiapi-engine: 134 tests en verde.scs-multiapi-maven-plugin: 1 test en verde.scs-multiapi-gradle-plugin:gradlew testBUILD SUCCESSFUL.Versión bumpada a 6.7.4 en los tres módulos.