Repository navigation
ci: guard the test database, run Playwright in CI, and drop 25 MB of dead files - #162
Merged
Merged
Conversation
The integration suite and Playwright's own server rewrite workspace state and add rows that are never removed, and cms/.env is loaded by default. Refuse unless the database name contains "test" or DATUM_TEST_DATABASE_OK=true. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- pipelineRun: close active runs before the onboarding-source check so the validation error is what is asserted, and require ActivePipelineRunError for the concurrent loser instead of any Error. - dirtyGuard: a clean form's link click is asserted unprevented, not compared with itself. - runPolling: spy on removeEventListener instead of relying on the stopped flag. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…equest runs - New e2e job: migrate, seed, install Chromium, run the suite, upload the HTML report on failure. Required by the ci aggregate job. - The integration and e2e jobs use a database named datum_test, which the new test-database guard requires. - cancel-in-progress only for pull requests, so two close merges to main both keep their run. - Playwright reports to the list and an HTML report that is never opened. - Playwright's own server gets SITE_URL, which the JSON-LD spec needs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…poll - redirects: ask for the first response (maxRedirects 0) and check the 307 and the location header; signed out, the final URL is always /admin/login. - adminPerformance: count only the evidence action's requests (the run bar also polls by POST every 15 s) and wait for hydration before clicking. The old spec failed with one extra POST when a poll landed in the window. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The E2E job's seed booted Payload with the dev schema push on, against a migration-built database, where a drizzle prompt exits 0 without seeding. Turn it off for the job, bump upload-artifact to v7, apply the test-database guard whether or not TEST_BASE_URL is set (the specs write through Payload either way), and wait for hydration before every interaction in the performance spec, plus a short settle before its "loaded once" check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pstack is installed per user from upstream instead of vendored. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Delete the 2026-09-11 audit screenshots and capture tooling (kept in history at 7bb204f), the shipped superpowers plans, and the open-source checklist that RELEASING.md supersedes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Untrack the force-added graph files and the merge=graphify attribute whose driver only existed in one machine's git config. Contributors build the graph with graphify update . after cloning. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The admin's tokens live in ops.css and are checked by dsContrast.int.spec.ts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
npm workspaces hoist both to the repo root. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Media is world-readable, so an SVG upload was served from the app origin. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ents Merge the split form-message, tpl-new and table th blocks; drop the repeated field input block, the pill restatement, the dead setup-row fallbacks and the unused --ops-sky-deco token. No visual change intended. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The dashboard loaded the whole crawled JSON on every render just to take its length. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ticles Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
NewContentView reads latestRun.status and nothing else; drop the other ten fields and the relationship-id helper that fed them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
`graphify hook install` registers a merge driver and writes the `.gitattributes` line this branch removes, so CONTRIBUTING now says not to run it. Move `countSitePages` above the setup-hub loader so its doc comment sits on the right function, and name the motion tokens the run bar uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first spec on a cold dev server clicked the nav toggler before React attached its handler, so the close was lost and the test failed on its first attempt in a full run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… URL `gotoHydrated` lost its wait in an earlier edit, so the performance spec still raced a cold dev server. The test-database guard also refuses a missing `DATABASE_URL`: Payload would then connect with libpq's defaults, which can name a working database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suites could quietly wreck a working database, the Playwright suite ran nowhere, and the repo carried 25 MB of things nothing uses. This closes the test, CI and hygiene findings from the project audit (follow-up to #160).
Tests and CI
DATABASE_URLdatabase name containstest, orDATUM_TEST_DATABASE_OK=trueis set. They rewrite workspace state and add append-only rows, andcms/.env(usually your working database) is loaded by default. A missingDATABASE_URLis refused too. If you run the suites against a per-worktree database whose name lackstest, rename it or set the opt-in.e2eCI job: migrate, seed (dev push off), install Chromium, run the 10 Playwright specs. CI databases are nowdatum_test.main.Hygiene
pstackplugin (vendor/claude-plugins, MIT, install it per user from upstream if wanted), the 96 audit screenshots and capture log (in history at7bb204f), and the two shipped plans.graphify-out/is no longer tracked and.gitattributes(a merge driver only one machine had) is gone. After pulling, existing clones lose their local graph files; rungraphify update .to rebuild. CONTRIBUTING now says not to rungraphify hook install, which recreates that driver.DESIGN.mdscoped to the public reader,cms/.vscodepaths fixed, dead and duplicateops.cssrules removed, narrower database reads on the setup hub and suggestion scan, stale "board" wording andconfigFingerprintdocs corrected,docs/open-source-checklist.mdremoved.Proof: typecheck, lint (0 warnings), pipeline 883/883, CMS integration 850/850 and
npm run build --workspace cmson this branch; the full Playwright suite 59/59 against Playwright's own dev server on a freshly migrated and seeded test database, plus the admin and performance specs repeated cold with no retries. The guard's test fails with the guard disabled, and each strengthened assertion was shown to fail against broken code. The newe2ejob itself first runs here.Reviewed with sol-loop: 2 rounds with GPT-6.1 Sol. Sol verdict: approved. Each workstream was also reviewed by Claude Opus 5.5 before integration.
Created with Claude Opus 5.5 in Claude Code; workstreams implemented by Claude Sonnet 5.5 subagents.
🤖 Generated with Claude Code