Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
uses: actions/checkout@v7

- name: Install Rust stable
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the action to a published Rust toolchain

On every CI run, this action interprets the numeric ref as the requested Rust toolchain, but Rust 1.120.0 has not been published; rustup toolchain install --help defines this argument as a toolchain name such as 1.8.0, and resolving 1.120.0 therefore fails while fetching its nonexistent channel manifest before fmt, clippy, or tests run. The same pin also blocks the changed macOS packaging and release workflows, so keep this on an available release such as 1.95.0 (or use the intended stable channel).

Useful? React with 👍 / 👎.

with:
components: rustfmt, clippy

Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
uses: actions/checkout@v7

- name: Install Rust stable
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0
with:
components: clippy

Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:

- name: Install Rust stable
id: toolchain
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0

- name: Cache cargo
uses: Swatinem/rust-cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/desktop-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:

- name: Install Rust stable
if: steps.prepare.outputs.build_required == 'true'
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0

- name: Cache cargo
if: steps.prepare.outputs.build_required == 'true'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
token: ${{ secrets.RELEASE_PLEASE_TOKEN || secrets.GITHUB_TOKEN }}

- name: Install Rust stable
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0

- name: Refresh workspace crate versions in Cargo.lock
run: cargo update --workspace
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
ref: ${{ needs.release-please.outputs.tag_name }}

- name: Install Rust stable
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0

- name: Cache cargo
uses: Swatinem/rust-cache@v2
Expand Down
Loading