[Collision] Set Data & Links to public in Collision models. Adopt state accessor for mstate. - #5969
Open
th-skam wants to merge 8 commits into
Open
[Collision] Set Data & Links to public in Collision models. Adopt state accessor for mstate.#5969th-skam wants to merge 8 commits into
th-skam wants to merge 8 commits into
Conversation
th-skam
added
pr: status to review
alxbilger
reviewed
Feb 25, 2026
alxbilger
left a comment
alxbilger
left a comment
Contributor
There was a problem hiding this comment.
Yes, Links and Data should be public. In any case, they can be accessed publicly (for example using findData, or in Python), so it makes sense that they are also public in C++.
As a side note, mstate should be a link too.
th-skam
added
pr: status wip
alxbilger
force-pushed
the
point-coli-public
branch
from
July 29, 2026 09:04
30a2e49 to
3b562e4
Compare
…, Tetra} CollisionModel
th-skam
force-pushed
the
point-coli-public
branch
from
August 10, 2026 13:11
3b562e4 to
9458431
Compare
th-skam
added
pr: status to review
Contributor
Author
|
Ended up with a bit of cleaning:
|
th-skam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of an inconsistency since the topology link (and Data) are mostly public in other model classes. Same with Sphere coli model.
Was this by design? Let's keep one consistent style for all models.
What do you think? should they be public or private?