Skip to content

[all] Fix compilation warnings - #6226

Open
hugtalbot wants to merge 3 commits into
masterfrom
202607_fix_warnings_claude
Open

[all] Fix compilation warnings#6226
hugtalbot wants to merge 3 commits into
masterfrom
202607_fix_warnings_claude

Conversation

@hugtalbot

Copy link
Copy Markdown
Contributor

Massively fix warnings for the pleasure

What was fixed

  • Unused parameters
  • Sign-compare
  • Deprecated barycentric API for you @epernod

Some points worth attention

-. BoxROI.inl was a genuine out-of-bounds read, not just a warning. isPointInAlignedBox looped to DataTypes::spatial_dimensions and indexed box[i+3], so for Vec6Types it read indices 6/7/8 of a Vec6. An axis-aligned box packed as (min₃, max₃) can't describe more than 3 dimensions, so I capped the loop at 3 and documented that higher dimensions are ignored.

  • CCDTightInclusionIntersection.cpp:187 — the bool from ticcd::edgeEdgeCCD is discarded and a contact is created unconditionally. That looks like a real bug, but acting on it changes collision behaviour, so I only silenced it ([[maybe_unused]] + a comment noting the call is kept for its toi/outputTolerance outputs). Your call whether it should early-return.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot
hugtalbot requested a review from epernod August 11, 2026 16:53
@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI labels Aug 11, 2026
@hugtalbot

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: AI-aided Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant