Repository navigation
Conversation
…stillness With minStableMs: 0 the tool settles on the first non-empty tree read, but the param description and the `settled` doc claimed the content had held still. Word both to match the behavior. Closes #1005
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-zero-stable-doc # Conflicts: # packages/tool-server/src/tools/await-screen-idle/index.ts
…-zero-stable-doc # Conflicts: # packages/tool-server/src/tools/await-screen-idle/index.ts
…cause; align skill wording
latekvo
left a comment
There was a problem hiding this comment.
[Diplomat, Opus 5.5]: Re-checked the wording at edc3bef against execute() and pollDescribeTree. I ran the real tool.execute on mocked tree sources for: every read throwing, a read that outruns timeoutMs, a read straddling the deadline, empty trees between identical reads, a stale HarmonyOS tree, abort, and the minStableMs/pollIntervalMs/timeoutMs boundaries. Each result matched the new text. Local tsc --build, eslint, prettier, the tool-server suites (329 tests), the installer skill suites and docusaurus build all pass.
Two problems sit outside this diff:
Closes #1005
With
minStableMs: 0,await-screen-idlesettles on the first non-empty tree read, but its prose (tool description, param description,settleddoc,tools.mdxrow,argent-device-interactskill) said the content had held still. The wording now holds for 0 too: 0 confirms content, not stillness.settled=falsealso names an unreadable tree as a cause, not only the timeout. Prose only; behavior is unchanged.Docs: the
await-screen-idlerow inreference/tools.mdx.Verification
Scratch vitest (not committed) running the real
tool.executeagainst a fake AX service. Its assertions check the prose, so "failed" below means the prose contradicted the observed result. Behavior is identical on both sides.minStableMs: 0, one content read:Dead tree source (every AX read throws), static screen:
Checks:
npx tsc --buildexit 0; tool-server vitest 229/229 acrossawait-screen-idle,await-harmony,ios-device-backgrounded-observation,interaction-messages,tool-input-schema-contract,tool-description-external-devices,skill-index-capabilities,harmony-flag-tool-text; prettier and eslint clean on touched files;npx docusaurus buildOK; SpiderShield gate passes at 9.07 (threshold 9.0), though it does not score this tool (#683).