Tap e2e test - #4318
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an Argent-driven “Basic Tap” end-to-end test flow and CI workflows to run it on Android and iOS, plus small UI/test hooks in the example app so the flow can reliably locate elements and assert gesture callback ordering.
Changes:
- Add Android and iOS GitHub Actions workflows to build the Expo example app and run the
simple-tap-testArgent flow. - Update the “Tap” example to expose a deterministic tap counter, log ordered gesture lifecycle events, and add a
testIDfor the tappable box. - Add missing
testIDs for console modal buttons and rename “Simple Gestures” entries to “Basic …” to match the test flow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/common-app/src/new_api/simple/tap/index.tsx | Adds tap counter UI, ordered logging, and testID for E2E automation. |
| apps/common-app/src/new_api/index.tsx | Renames “Simple Gestures” examples to “Basic …” for discoverability/E2E selection. |
| apps/common-app/src/console/ConsoleModal.tsx | Adds testIDs needed for console interactions in the E2E flow. |
| .github/workflows/ios-e2e.yml | New CI workflow to build iOS simulator app and run Argent tap flow. |
| .github/workflows/android-e2e.yml | New CI workflow to build Android app, boot emulator, and run Argent tap flow. |
| .argent/flows/simple-tap-test.yaml | Defines the Argent flow steps/assertions for the “Basic Tap” E2E test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const tapGesture = useTapGesture({ | ||
| onBegin: () => { | ||
| log('onBegin'); | ||
| colorProgress.value = withTiming(1, { | ||
| duration: 100, | ||
| }); | ||
| }, | ||
| onActivate: () => { | ||
| log('onActivate'); | ||
| scheduleOnRN(setCount, count + 1); | ||
| }, |
958acd2 to
085d4c1
Compare
69c7aba to
25e2de2
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
25e2de2 to
9dcd552
Compare
0332446 to
55d2a77
Compare
Print log, move server start android Update android action Move sim server start out of emulator step Remove dependencies
4730e25 to
320417d
Compare
Description
Test plan