remove student discord ID from queue history CSV - #52
Open
TwoLettuce wants to merge 1 commit into
Open
Conversation
That field is ignored when retrieving the table data, so including it in the header was offsetting some of the column names.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new header.remove("student_discord_id") can raise ValueError if the column name is absent (schema drift/rename), making CSV export fragile.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the student_discord_id column from the generated queue history CSV header so the exported CSV columns align with the row data being written.
Changes:
- Drops
student_discord_idfrom the CSV header produced byget_queue_history_as_csv().
File summaries
| File | Description |
|---|---|
| src/data_access/queue_history_dao.py | Removes student_discord_id from the CSV header to fix column offset/misalignment. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| """ | ||
| ) | ||
| header = [row["COLUMN_NAME"] for row in await cursor.fetchall()] | ||
| header.remove("student_discord_id") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That field is ignored when retrieving the table data, so including it in the header was offsetting some of the column names.