fix: show error state when repository status fails to load#1434
Open
The-AarushiSingh wants to merge 1 commit into
Open
fix: show error state when repository status fails to load#1434The-AarushiSingh wants to merge 1 commit into
The-AarushiSingh wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesRepository indexing guard
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaced the placeholder
return nullerror branch inRepoIndexedGuardwith an inline error state using the sharedAlertcomponent.This provides users with feedback when the repository status request fails instead of rendering a blank page.
Testing
Verified the component builds successfully.
Confirmed the change does not affect the existing loading, polling, or notification behavior.
Note
Low Risk
UI-only error handling in AskGH; no changes to API calls, auth, or indexing logic.
Overview
When the
repo-statusquery inRepoIndexedGuardfails, users now see a centered destructiveAlert(“Unable to load repository status”) instead of a blank page from the previousreturn nullplaceholder.Imports add the shared
Alertcomponents andAlertCircleicon; indexing spinner, polling, and ready notifications are unchanged.Reviewed by Cursor Bugbot for commit 0879eff. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit